Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: axboe@fb.com (Jens Axboe)
Subject: [PATCHv2 01/10] blk-mq: Wake tasks entering queue on dying
Date: Wed, 7 Jan 2015 09:18:56 -0700	[thread overview]
Message-ID: <54AD5C70.1050901@fb.com> (raw)
In-Reply-To: <1420599484-21582-2-git-send-email-keith.busch@intel.com>

On 01/06/2015 07:57 PM, Keith Busch wrote:
> When the queue is set to dying, wake up tasks that are waiting on frozen
> queue so they realize it is dying and abandon their request.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
>   block/blk-mq.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 1a41d7a..6d83ee6 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -160,6 +160,7 @@ void blk_mq_wake_waiters(struct request_queue *q)
>   	queue_for_each_hw_ctx(q, hctx, i)
>   		if (blk_mq_hw_queue_mapped(hctx))
>   			blk_mq_tag_wakeup_all(hctx->tags, true);
> +	wake_up_all(&q->mq_freeze_wq);
>   }
>
>   bool blk_mq_can_queue(struct blk_mq_hw_ctx *hctx)

That looks sane, thanks.

-- 
Jens Axboe

  reply	other threads:[~2015-01-07 16:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07  2:57 [PATCHv2 00/10] Second attempt at blk-mq + nvme hotplug fixes Keith Busch
2015-01-07  2:57 ` [PATCHv2 01/10] blk-mq: Wake tasks entering queue on dying Keith Busch
2015-01-07 16:18   ` Jens Axboe [this message]
2015-01-07  2:57 ` [PATCHv2 02/10] blk-mq: Export test for started requests Keith Busch
2015-01-07  2:57 ` [PATCHv2 03/10] blk-mq: Let drivers cancel requeue_work Keith Busch
2015-01-07  2:57 ` [PATCHv2 04/10] blk-mq: Export abort requeue list Keith Busch
2015-01-07  2:57 ` [PATCHv2 05/10] blk-mq: Allow requests to never expire Keith Busch
2015-01-07 16:16   ` Jens Axboe
2015-01-07  2:58 ` [PATCHv2 06/10] blk-mq: End unstarted requests on a dying queue Keith Busch
2015-01-07  2:58 ` [PATCHv2 07/10] NVMe: Start driver allocated requests Keith Busch
2015-01-07  2:58 ` [PATCHv2 08/10] NVMe: Start and stop h/w queues on reset Keith Busch
2015-01-07  3:08   ` Keith Busch
2015-01-07  2:58 ` [PATCHv2 09/10] NVMe: Admin queue error handling Keith Busch
2015-01-07  2:58 ` [PATCHv2 10/10] NVMe: Command abort handling fixes Keith Busch
2015-01-07  7:42 ` [PATCHv2 00/10] Second attempt at blk-mq + nvme hotplug fixes Ming Lin
2015-01-07 16:20   ` Keith Busch
2015-01-07 19:36     ` Ming Lin
2015-01-07 16:22 ` Jens Axboe
2015-01-07 16:31   ` Keith Busch
2015-01-07 16:34     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD5C70.1050901@fb.com \
    --to=axboe@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox