Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: axboe@fb.com (Jens Axboe)
Subject: [PATCHv2 00/10] Second attempt at blk-mq + nvme hotplug fixes
Date: Wed, 7 Jan 2015 09:34:30 -0700	[thread overview]
Message-ID: <54AD6016.7060306@fb.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1501071626500.4026@localhost.lm.intel.com>

On 01/07/2015 09:31 AM, Keith Busch wrote:
> On Wed, 7 Jan 2015, Jens Axboe wrote:
>> On 01/06/2015 07:57 PM, Keith Busch wrote:
>>> Second try, this time tested against many more scenarios than before
>>> with error injection and surprise hot-removal and intermittent resets.
>>>
>>> I'm adding a lot of stuff outside the driver, but I didn't find a
>>> cleaner way to a lot of these things. This makes me a little nervous,
>>> so please let me know if anything seems amiss here. I don't think any
>>> of the blk-mq changes could possibly be harmful to anyone else since
>>> nvme is the only driver that uses most of the additions.
>>>
>>> The only issue remaining I found is unfreezing queues might tigger the
>>> percpu_ref_reinit WARN_ON_ONCE when the driver restarts a request_queue
>>> with queued up IO's.
>>>
>>> This is against linux-block/for-next.
>>
>> Series looks sane to me, apart from the timeout change I replied to
>> separately. Could you turn that into a request flag and respin the
>> series on top of that?
>
> Thanks a bunch, I'll respin the series with the no-timeout request flag,
> correct irq spin locking I found in [8/10], and fix attribution in [4/10].

Awesome, thanks Keith! And thanks for taking the time to get this sorted.

-- 
Jens Axboe

      reply	other threads:[~2015-01-07 16:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07  2:57 [PATCHv2 00/10] Second attempt at blk-mq + nvme hotplug fixes Keith Busch
2015-01-07  2:57 ` [PATCHv2 01/10] blk-mq: Wake tasks entering queue on dying Keith Busch
2015-01-07 16:18   ` Jens Axboe
2015-01-07  2:57 ` [PATCHv2 02/10] blk-mq: Export test for started requests Keith Busch
2015-01-07  2:57 ` [PATCHv2 03/10] blk-mq: Let drivers cancel requeue_work Keith Busch
2015-01-07  2:57 ` [PATCHv2 04/10] blk-mq: Export abort requeue list Keith Busch
2015-01-07  2:57 ` [PATCHv2 05/10] blk-mq: Allow requests to never expire Keith Busch
2015-01-07 16:16   ` Jens Axboe
2015-01-07  2:58 ` [PATCHv2 06/10] blk-mq: End unstarted requests on a dying queue Keith Busch
2015-01-07  2:58 ` [PATCHv2 07/10] NVMe: Start driver allocated requests Keith Busch
2015-01-07  2:58 ` [PATCHv2 08/10] NVMe: Start and stop h/w queues on reset Keith Busch
2015-01-07  3:08   ` Keith Busch
2015-01-07  2:58 ` [PATCHv2 09/10] NVMe: Admin queue error handling Keith Busch
2015-01-07  2:58 ` [PATCHv2 10/10] NVMe: Command abort handling fixes Keith Busch
2015-01-07  7:42 ` [PATCHv2 00/10] Second attempt at blk-mq + nvme hotplug fixes Ming Lin
2015-01-07 16:20   ` Keith Busch
2015-01-07 19:36     ` Ming Lin
2015-01-07 16:22 ` Jens Axboe
2015-01-07 16:31   ` Keith Busch
2015-01-07 16:34     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD6016.7060306@fb.com \
    --to=axboe@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox