Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH for-4.0-rc6] NVMe: Initialize device list head before starting
@ 2015-03-23 15:32 Keith Busch
  2015-03-23 16:16 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Keith Busch @ 2015-03-23 15:32 UTC (permalink / raw)


Driver recovery requires the device's list node to have been initialized.

Fixes: https://lkml.org/lkml/2015/3/22/262

Reported-by: Steven Noonan <steven at uplinklabs.net>
Signed-off-by: Keith Busch <keith.busch at intel.com>
Cc: Matthew Wilcox <willy at linux.intel.com>
Cc: Jens Axboe <axboe at fb.com>
---
 drivers/block/nvme-core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index ceb32dd..e23be20 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -3003,6 +3003,7 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	}
 	get_device(dev->device);
 
+	INIT_LIST_HEAD(&dev->node);
 	INIT_WORK(&dev->probe_work, nvme_async_probe);
 	schedule_work(&dev->probe_work);
 	return 0;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH for-4.0-rc6] NVMe: Initialize device list head before starting
  2015-03-23 15:32 [PATCH for-4.0-rc6] NVMe: Initialize device list head before starting Keith Busch
@ 2015-03-23 16:16 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2015-03-23 16:16 UTC (permalink / raw)


On 03/23/2015 09:32 AM, Keith Busch wrote:
> Driver recovery requires the device's list node to have been initialized.
>
> Fixes: https://lkml.org/lkml/2015/3/22/262
>
> Reported-by: Steven Noonan <steven at uplinklabs.net>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> Cc: Matthew Wilcox <willy at linux.intel.com>
> Cc: Jens Axboe <axboe at fb.com>

I have applied this for the current series.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-23 16:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-23 15:32 [PATCH for-4.0-rc6] NVMe: Initialize device list head before starting Keith Busch
2015-03-23 16:16 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox