Re: [PATCH v3 2/2] nvme: initialize known effects to set ns_mgmt NCC and ns_attach NIC

[Tokunori Ikegami <ikegami.t@gmail.com>]

On 2026/04/28 15:51, Keith Busch wrote:
> I suppose that's why the "known_effects" exists, but it'd be
> dissappointing if we really need this. The other opcodes in there
> existed before the Command Effects Log was created, so understandable
> that controllers may not implement it. But NS management/attach were
> introduced after the log, and there is also the AEN that the driver
> could rescan on receipt, so it's doubly bad if a controller
> implementation really needs this.

Just rechecked the specification again then the log page identifier: 
commands supported and effects mentioned is optional for NVM express 
revision 1.4 and earlier then for the older controller the changes not 
bad I think.
By the way about the scan_work executions for the command effects log 
and AEN I thought it is better to be handled only once but I do not have 
an actual idea for the exclusive control.
Thank you.