From: Keith Busch <kbusch@kernel.org>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3 2/2] nvme: initialize known effects to set ns_mgmt NCC and ns_attach NIC
Date: Tue, 28 Apr 2026 07:51:39 +0100 [thread overview]
Message-ID: <afBY-0abdJwOfwxs@kbusch-mbp.client.m3-hotspots.de> (raw)
In-Reply-To: <20260425130426.10061-3-ikegami.t@gmail.com>
On Sat, Apr 25, 2026 at 10:04:13PM +0900, Tokunori Ikegami wrote:
> This is to make sure scan_work done for the commands.
> Since nvme_passthru_end called when effects set.
> Also scan_work is flushed when NIC or NCC effects set.
>
> The change is to improvement the scan_work to make sure.
> Always do scan for the ns_mgmt and ns_attach commands.
> All drives supporting ns_mgmt and ns_attach should have the entries.
> But no need to be depended on it as always do scan.
I suppose that's why the "known_effects" exists, but it'd be
dissappointing if we really need this. The other opcodes in there
existed before the Command Effects Log was created, so understandable
that controllers may not implement it. But NS management/attach were
introduced after the log, and there is also the AEN that the driver
could rescan on receipt, so it's doubly bad if a controller
implementation really needs this.
next prev parent reply other threads:[~2026-04-28 6:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 13:04 [PATCH v3 0/2] scan_work improvement Tokunori Ikegami
2026-04-25 13:04 ` [PATCH v3 1/2] nvme: delete unnecessary empty lines Tokunori Ikegami
2026-04-25 13:04 ` [PATCH v3 2/2] nvme: initialize known effects to set ns_mgmt NCC and ns_attach NIC Tokunori Ikegami
2026-04-28 6:51 ` Keith Busch [this message]
2026-04-29 6:08 ` Tokunori Ikegami
2026-04-29 8:48 ` Keith Busch
2026-04-29 12:49 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afBY-0abdJwOfwxs@kbusch-mbp.client.m3-hotspots.de \
--to=kbusch@kernel.org \
--cc=hch@infradead.org \
--cc=ikegami.t@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox