Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCH RFC] nvme-core: Log the ctrl device instance name
Date: Sun, 10 Jan 2016 14:44:55 +0200	[thread overview]
Message-ID: <56925247.8080409@dev.mellanox.co.il> (raw)
In-Reply-To: <1452416444-22714-1-git-send-email-sagig@mellanox.com>


>   	if (nvme_identify_ns(ns->ctrl, ns->ns_id, &id)) {
> -		dev_warn(ns->ctrl->dev, "%s: Identify failure nvme%dn%d\n",
> +		dev_warn(ns->ctrl->device, "%s: Identify failure nvme%dn%d\n",
>   				__func__, ns->ctrl->instance, ns->ns_id);

Oops,

That ought to be replaced with:
		dev_warn(disk_to_dev(ns->disk, "%s: Identify failure\n",
				__func__);

  reply	other threads:[~2016-01-10 12:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-10  9:00 [PATCH RFC] nvme-core: Log the ctrl device instance name Sagi Grimberg
2016-01-10 12:44 ` Sagi Grimberg [this message]
2016-01-13  7:57 ` Sagi Grimberg
2016-01-15 16:40 ` Keith Busch
2016-01-17  8:54   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56925247.8080409@dev.mellanox.co.il \
    --to=sagig@dev.mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox