Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCH RFC] nvme-core: Log the ctrl device instance name
Date: Sun, 17 Jan 2016 10:54:35 +0200	[thread overview]
Message-ID: <569B56CB.5090107@dev.mellanox.co.il> (raw)
In-Reply-To: <20160115164031.GA11165@localhost.localdomain>


>> Having the ctrl instance name "nvmeX" seems much more friendly than
>> the underlying device name. Also, with other nvme transports
>> such as the soon to come nvme-loop we don't have an underlying
>> device and it doesn't makes sense to make up one.
>
> For PCI, I think this is okay if you add a message each time a device gets
> an instance that ties it back to PCI device's name. Without something
> like that, it doesn't look straight forward to match the NVMe device
> name to it's PCI function just from the logs.

That sounds ok to me too.

So I'll convert the pci.c logging as well and add a log message that
ties an instance to a pci function.

Thanks Keith!

      reply	other threads:[~2016-01-17  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-10  9:00 [PATCH RFC] nvme-core: Log the ctrl device instance name Sagi Grimberg
2016-01-10 12:44 ` Sagi Grimberg
2016-01-13  7:57 ` Sagi Grimberg
2016-01-15 16:40 ` Keith Busch
2016-01-17  8:54   ` Sagi Grimberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569B56CB.5090107@dev.mellanox.co.il \
    --to=sagig@dev.mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox