From: logang@deltatee.com (Logan Gunthorpe)
Subject: [PATCH 3/4] nvmet-fc: Don't use the count returned by the dma_map_sg call
Date: Thu, 29 Mar 2018 10:30:34 -0600 [thread overview]
Message-ID: <5ba62675-39b4-6409-5628-c59d8ae048de@deltatee.com> (raw)
In-Reply-To: <03cb3610-8ec7-9dc4-9e0a-82f4c30de578@broadcom.com>
On 29/03/18 10:24 AM, James Smart wrote:
> Signed-off-by: James Smart? <james.smart at broadcom.com>
Thanks James.
> As for "not used anywhere", be careful as the structure being prepped is
> passed from the nvme-fc transport to an underlying lldd. So the
> references would likely be in the lldd.
Can you elaborate? The 'data_sg_cnt' member was in 'struct
nvmet_fc_fcp_iod' which is declared in fc.c so it doesn't seem sane for
lower driver to access it... In fact the next patch in the series
removes it completely.
Logan
next prev parent reply other threads:[~2018-03-29 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 16:07 [PATCH 0/4] SGL alloc and free helper functions for requests Logan Gunthorpe
2018-03-29 16:07 ` [PATCH 1/4] nvmet: Introduce helper functions to allocate and free request SGLs Logan Gunthorpe
2018-03-29 16:07 ` [PATCH 2/4] nvmet-rdma: Use new SGL alloc/free helper for requests Logan Gunthorpe
2018-04-04 12:43 ` Sagi Grimberg
2018-04-04 16:47 ` Logan Gunthorpe
2018-03-29 16:07 ` [PATCH 3/4] nvmet-fc: Don't use the count returned by the dma_map_sg call Logan Gunthorpe
2018-03-29 16:14 ` Bart Van Assche
2018-03-29 16:15 ` Logan Gunthorpe
2018-03-29 16:38 ` Logan Gunthorpe
2018-03-29 16:24 ` James Smart
2018-03-29 16:30 ` Logan Gunthorpe [this message]
2018-03-29 16:34 ` James Smart
2018-04-04 12:45 ` Sagi Grimberg
2018-03-29 16:07 ` [PATCH 4/4] nvmet-fc: Use new SGL alloc/free helper for requests Logan Gunthorpe
2018-03-29 16:52 ` James Smart
2018-03-29 17:02 ` Logan Gunthorpe
2018-03-29 17:39 ` James Smart
2018-03-29 18:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba62675-39b4-6409-5628-c59d8ae048de@deltatee.com \
--to=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox