Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: logang@deltatee.com (Logan Gunthorpe)
Subject: [PATCH 3/4] nvmet-fc: Don't use the count returned by the dma_map_sg call
Date: Thu, 29 Mar 2018 10:38:45 -0600	[thread overview]
Message-ID: <ec0f4fb3-33be-4343-0ee5-8fcb646e3345@deltatee.com> (raw)
In-Reply-To: <a60ddb463159bcc287998ecfafdc2753973a4828.camel@wdc.com>



On 29/03/18 10:14 AM, Bart Van Assche wrote:
> On Thu, 2018-03-29@10:07 -0600, Logan Gunthorpe wrote:
>> +	ret = fc_dma_map_sg(fod->tgtport->dev, sg, nent,
>> +			    ((fod->io_dir == NVMET_FCP_WRITE) ?
>> +				    DMA_FROM_DEVICE : DMA_TO_DEVICE));
>> +			    /* note: write from initiator perspective */
> 
> If you have to repost this patch please remove the four superfluous parentheses.

Oh, actually, I made this change in patch 4 of this series for the next
time I post it. This allowed me to cleanup both the map and unmap
instances in the same patch.

Also, if the maintainer wants to pick up patch 3 as a bug fix I can
carry the rest in the P2PDMA series.

Thanks,

Logan

  parent reply	other threads:[~2018-03-29 16:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 16:07 [PATCH 0/4] SGL alloc and free helper functions for requests Logan Gunthorpe
2018-03-29 16:07 ` [PATCH 1/4] nvmet: Introduce helper functions to allocate and free request SGLs Logan Gunthorpe
2018-03-29 16:07 ` [PATCH 2/4] nvmet-rdma: Use new SGL alloc/free helper for requests Logan Gunthorpe
2018-04-04 12:43   ` Sagi Grimberg
2018-04-04 16:47     ` Logan Gunthorpe
2018-03-29 16:07 ` [PATCH 3/4] nvmet-fc: Don't use the count returned by the dma_map_sg call Logan Gunthorpe
2018-03-29 16:14   ` Bart Van Assche
2018-03-29 16:15     ` Logan Gunthorpe
2018-03-29 16:38     ` Logan Gunthorpe [this message]
2018-03-29 16:24   ` James Smart
2018-03-29 16:30     ` Logan Gunthorpe
2018-03-29 16:34       ` James Smart
2018-04-04 12:45   ` Sagi Grimberg
2018-03-29 16:07 ` [PATCH 4/4] nvmet-fc: Use new SGL alloc/free helper for requests Logan Gunthorpe
2018-03-29 16:52   ` James Smart
2018-03-29 17:02     ` Logan Gunthorpe
2018-03-29 17:39       ` James Smart
2018-03-29 18:15       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec0f4fb3-33be-4343-0ee5-8fcb646e3345@deltatee.com \
    --to=logang@deltatee.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox