From: Nilay Shroff <nilay@linux.ibm.com>
To: Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Cc: hch@lst.de, kbusch@kernel.org, hare@suse.de, jmeneghi@redhat.com,
axboe@kernel.dk, martin.petersen@oracle.com, gjoyce@ibm.com
Subject: Re: [RFC PATCHv2 1/3] nvme-multipath: introduce delayed removal of the multipath head node
Date: Mon, 28 Apr 2025 13:09:59 +0530 [thread overview]
Message-ID: <6305bdd1-97bd-44a5-98f7-a167b7c64c0d@linux.ibm.com> (raw)
In-Reply-To: <859e8758-83a2-46d2-81ed-c5199f326508@grimberg.me>
On 4/26/25 3:56 AM, Sagi Grimberg wrote:
>> @@ -3688,6 +3688,8 @@ static struct nvme_ns_head *nvme_alloc_ns_head(struct nvme_ctrl *ctrl,
>> ratelimit_state_init(&head->rs_nuse, 5 * HZ, 1);
>> ratelimit_set_flags(&head->rs_nuse, RATELIMIT_MSG_ON_RELEASE);
>> kref_init(&head->ref);
>> + if (ctrl->opts)
>
> While this check is correct, perhaps checking ctrl->ops->flags & NVME_F_FABRICS
> would be clearer.
>
Sure, I'd update this in the next patch.
Thanks,
--Nilay
next prev parent reply other threads:[~2025-04-28 7:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 10:33 [RFC PATCHv2 0/3] improve NVMe multipath handling Nilay Shroff
2025-04-25 10:33 ` [RFC PATCHv2 1/3] nvme-multipath: introduce delayed removal of the multipath head node Nilay Shroff
2025-04-25 14:43 ` Christoph Hellwig
2025-04-28 7:05 ` Nilay Shroff
2025-04-25 22:26 ` Sagi Grimberg
2025-04-28 7:39 ` Nilay Shroff [this message]
2025-04-25 10:33 ` [RFC PATCHv2 2/3] nvme: introduce multipath_head_always module param Nilay Shroff
2025-04-25 14:45 ` Christoph Hellwig
2025-04-29 6:26 ` Nilay Shroff
2025-04-28 6:57 ` Hannes Reinecke
2025-04-28 7:39 ` Nilay Shroff
2025-04-29 5:49 ` Hannes Reinecke
2025-04-29 6:24 ` Nilay Shroff
2025-04-29 7:01 ` Hannes Reinecke
2025-04-29 7:15 ` Nilay Shroff
2025-04-25 10:33 ` [RFC PATCHv2 3/3] nvme: rename nvme_mpath_shutdown_disk to nvme_mpath_remove_disk Nilay Shroff
2025-04-25 14:46 ` Christoph Hellwig
2025-04-25 22:27 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6305bdd1-97bd-44a5-98f7-a167b7c64c0d@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox