Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH rfc v2 08/10] nvme-cli: Expand --device argument processing
Date: Fri, 12 Jul 2019 16:10:37 +0200	[thread overview]
Message-ID: <6699bf8a-b78e-ed9f-e579-e4f96440b5f9@suse.de> (raw)
In-Reply-To: <20190712003140.16221-9-jsmart2021@gmail.com>

On 7/12/19 2:31 AM, James Smart wrote:
> The connect-all --device argument was used to specify a specific device
> to be used as the discovery controller. The device is typically a
> long-lived discovery controller that posted a discovery event.
> No attempt was made to ensure the device is who it is supposed to be
> before using it.
> 
> Revised the code to use the other arguments in the connect-all request
> to validate that the device is the entity that was expected. If the
> device doesn't match, the cli will look for an existing matching device
> in the system (should be a discovery controller due to nqn) with the
> same connect parameters and use it.  If one is not found on the system,
> a new discovery controller will be created for the connect-all request.
> 
> The revision uses new routines to parse the connect arguments given
> in the argstr parameter. As a couple of new fieldnames are needed, the
> parse routine constants were expanded for them.
> 
> The revision uses the new routines to match the specified device vs
> it's attributes as well as the search routine that looks for a device
> with the connect arguments.
> 
> Signed-off-by: James Smart <jsmart2021 at gmail.com>
> CC: Sagi Grimberg <sagi at grimberg.me>
> CC: Hannes Reinecke <hare at suse.com>
> ---
>  fabrics.c | 38 ++++++++++++++++++++++++++++++++++++++
>  nvme.c    |  2 ++
>  nvme.h    |  2 ++
>  3 files changed, 42 insertions(+)
> 
Reviewed-by: Hannes Reinecke <hare at suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG N?rnberg)

  parent reply	other threads:[~2019-07-12 14:10 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  0:31 [PATCH rfc v2 00/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-12  0:31 ` [PATCH rfc v2 01/10] nvme-cli: ignore arguments that pass in "none" James Smart
2019-07-12  0:31 ` [PATCH rfc v2 02/10] nvme-cli: support persistent connections to a discovery controller James Smart
2019-07-12  0:31 ` [PATCH rfc v2 03/10] nvme-cli: allow discover to address discovery controller by persistent name James Smart
2019-07-12  1:34   ` Minwoo Im
2019-07-12 12:41   ` Hannes Reinecke
2019-07-12 16:37   ` Sagi Grimberg
2019-07-12  0:31 ` [PATCH rfc v2 04/10] nvme-cli: Refactor to create a get_nvme_ctrl_info routine James Smart
2019-07-12  0:50   ` Sagi Grimberg
2019-07-12  6:20   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 05/10] nvme-cli: extend ctrl_list_item for connect attributes James Smart
2019-07-12  0:47   ` Sagi Grimberg
2019-07-16  0:11     ` James Smart
2019-07-16  1:13       ` Sagi Grimberg
2019-07-12  6:24   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 06/10] nvme-cli: Add routine to compare ctrl_list_item to connect args James Smart
2019-07-12  0:49   ` Sagi Grimberg
2019-07-12  6:25   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 07/10] nvme-cli: Add routine to search for controller with specific attributes James Smart
2019-07-12  0:50   ` Sagi Grimberg
2019-07-12  6:28   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 08/10] nvme-cli: Expand --device argument processing James Smart
2019-07-12  0:51   ` Sagi Grimberg
2019-07-12 14:10   ` Hannes Reinecke [this message]
2019-07-12  0:31 ` [PATCH rfc v2 09/10] nvme-cli: add --quiet option James Smart
2019-07-12 17:35   ` Sagi Grimberg
2019-07-14 14:49     ` James Smart
2019-07-15 23:34       ` James Smart
2019-07-12  0:31 ` [PATCH rfc v2 10/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-12  0:42   ` Sagi Grimberg
2019-07-12 17:26   ` Sagi Grimberg
2019-07-14 14:47     ` James Smart
2019-07-15 17:20       ` Sagi Grimberg
2019-07-12 17:55   ` Sagi Grimberg
2019-07-14 14:49     ` James Smart
2019-07-12 17:58   ` Sagi Grimberg
2019-07-14 14:57     ` James Smart
2019-07-15 17:21       ` Sagi Grimberg
2019-07-15 19:04         ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6699bf8a-b78e-ed9f-e579-e4f96440b5f9@suse.de \
    --to=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox