Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: james.smart@broadcom.com (James Smart)
Subject: [PATCH rfc v2 10/10] nvme-cli: nvmf auto-connect scripts
Date: Sun, 14 Jul 2019 07:57:46 -0700	[thread overview]
Message-ID: <e45db042-2cf0-2922-cceb-ff593711e42f@broadcom.com> (raw)
In-Reply-To: <9c08054d-751e-fdc0-4ea1-64cfa388e439@grimberg.me>



On 7/12/2019 10:58 AM, Sagi Grimberg wrote:
>
>> diff --git a/Makefile b/Makefile
>> index db594a3..4ea8b41 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -8,6 +8,10 @@ DESTDIR =
>> ? PREFIX ?= /usr/local
>> ? SYSCONFDIR = /etc
>> ? SBINDIR = $(PREFIX)/sbin
>> +LIBDIR ?= /usr/lib
>> +SYSTEMDDIR ?= $(LIBDIR)/systemd
>> +UDEVDIR ?= $(LIBDIR)/udev
>
> UDEVDIR needs to be built from $(SYSCONFDIR)/udev as LIBDIR might be
> /usr/local/lib and udev doesn't look there.

I really would like to change prefix to /usr, so that it matches what is 
in nvme.spec.in where the %install paragraph sets PREFIX to /usr.?? We 
have two separate places setting a value and they are in conflict.

Based on the spec file setting - the only make targets that match PREFIX 
outside of the install targets is the pkg target which is mainly man 
files and a copy of nvme.? The man files perhaps would be under 
/usr/local, but everything else we're talking about would be very odd 
under /usr/local.?? Perhaps a better answer is PREFIX=/usr (which also 
set SBINDIR for the nvme copy), LIBDIR=$(PREFIX)/lib, other variables 
the same, and add a MANPREFIX=/usr/local for the man files.

-- james

  reply	other threads:[~2019-07-14 14:57 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  0:31 [PATCH rfc v2 00/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-12  0:31 ` [PATCH rfc v2 01/10] nvme-cli: ignore arguments that pass in "none" James Smart
2019-07-12  0:31 ` [PATCH rfc v2 02/10] nvme-cli: support persistent connections to a discovery controller James Smart
2019-07-12  0:31 ` [PATCH rfc v2 03/10] nvme-cli: allow discover to address discovery controller by persistent name James Smart
2019-07-12  1:34   ` Minwoo Im
2019-07-12 12:41   ` Hannes Reinecke
2019-07-12 16:37   ` Sagi Grimberg
2019-07-12  0:31 ` [PATCH rfc v2 04/10] nvme-cli: Refactor to create a get_nvme_ctrl_info routine James Smart
2019-07-12  0:50   ` Sagi Grimberg
2019-07-12  6:20   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 05/10] nvme-cli: extend ctrl_list_item for connect attributes James Smart
2019-07-12  0:47   ` Sagi Grimberg
2019-07-16  0:11     ` James Smart
2019-07-16  1:13       ` Sagi Grimberg
2019-07-12  6:24   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 06/10] nvme-cli: Add routine to compare ctrl_list_item to connect args James Smart
2019-07-12  0:49   ` Sagi Grimberg
2019-07-12  6:25   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 07/10] nvme-cli: Add routine to search for controller with specific attributes James Smart
2019-07-12  0:50   ` Sagi Grimberg
2019-07-12  6:28   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 08/10] nvme-cli: Expand --device argument processing James Smart
2019-07-12  0:51   ` Sagi Grimberg
2019-07-12 14:10   ` Hannes Reinecke
2019-07-12  0:31 ` [PATCH rfc v2 09/10] nvme-cli: add --quiet option James Smart
2019-07-12 17:35   ` Sagi Grimberg
2019-07-14 14:49     ` James Smart
2019-07-15 23:34       ` James Smart
2019-07-12  0:31 ` [PATCH rfc v2 10/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-12  0:42   ` Sagi Grimberg
2019-07-12 17:26   ` Sagi Grimberg
2019-07-14 14:47     ` James Smart
2019-07-15 17:20       ` Sagi Grimberg
2019-07-12 17:55   ` Sagi Grimberg
2019-07-14 14:49     ` James Smart
2019-07-12 17:58   ` Sagi Grimberg
2019-07-14 14:57     ` James Smart [this message]
2019-07-15 17:21       ` Sagi Grimberg
2019-07-15 19:04         ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e45db042-2cf0-2922-cceb-ff593711e42f@broadcom.com \
    --to=james.smart@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox