[PATCH] nvme: fix incorrect sizeof

[PATCH] nvme: fix incorrect sizeof

[Kanchan Joshi]

Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.

Fixes: 38e8397dde63 ("nvme: use fdp streams if write stream is provided")
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 52331a14bce1..7c1b9f2bf0ae 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2296,7 +2296,7 @@ static int nvme_query_fdp_info(struct nvme_ns *ns, struct nvme_ns_info *info)
 	if (!head->nr_plids)
 		goto free;
 
-	head->plids = kcalloc(head->nr_plids, sizeof(head->plids),
+	head->plids = kcalloc(head->nr_plids, sizeof(*head->plids),
 			      GFP_KERNEL);
 	if (!head->plids) {
 		dev_warn(ctrl->device,
-- 
2.25.1

Re: [PATCH] nvme: fix incorrect sizeof

[Caleb Sander Mateos]

On Tue, May 6, 2025 at 11:05 AM Kanchan Joshi <joshi.k@samsung.com> wrote:
>
> Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.
>
> Fixes: 38e8397dde63 ("nvme: use fdp streams if write stream is provided")
> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>

Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>

Re: [PATCH] nvme: fix incorrect sizeof

[Jens Axboe]

On 5/6/25 11:56 AM, Kanchan Joshi wrote:
> Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.
> 
> Fixes: 38e8397dde63 ("nvme: use fdp streams if write stream is provided")
> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>

Reported-by: Caleb Sander Mateos <csander@purestorage.com>

?

-- 
Jens Axboe

Re: [PATCH] nvme: fix incorrect sizeof

[Caleb Sander Mateos]

On Tue, May 6, 2025 at 11:09 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 5/6/25 11:56 AM, Kanchan Joshi wrote:
> > Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.
> >
> > Fixes: 38e8397dde63 ("nvme: use fdp streams if write stream is provided")
> > Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
>
> Reported-by: Caleb Sander Mateos <csander@purestorage.com>
>
> ?

Yeah, if you wouldn't mind, I'd appreciate that.

Best,
Caleb

Re: [PATCH] nvme: fix incorrect sizeof

[Kanchan Joshi/Kanchan Joshi]

On 5/6/2025 11:39 PM, Jens Axboe wrote:
> Reported-by: Caleb Sander Mateos<csander@purestorage.com>
> 
> ?

indeed, missed that :-(

Re: [PATCH] nvme: fix incorrect sizeof

[Jens Axboe]

On 5/6/25 12:25 PM, Kanchan Joshi/Kanchan Joshi wrote:
> On 5/6/2025 11:39 PM, Jens Axboe wrote:
>> Reported-by: Caleb Sander Mateos<csander@purestorage.com>
>>
>> ?
> 
> indeed, missed that :-(

The commit message is also very light. I know it's a basic issue, but
let's at least try to have a full description of the issue.

Can you send a v2 correcting those things?

-- 
Jens Axboe