[PATCH v2] nvmet: pci-epf: fix DMA channel debug print

[PATCH v2] nvmet: pci-epf: fix DMA channel debug print

[Shin'ichiro Kawasaki]

Currently, nvmet_pci_epf_init_dma() has two dev_dbg() calls intended to
print debug information about the DMA channels for RX and TX. However,
both calls mistakenly are made for the TX channel. Fix it by referreing
to 'nvme_epf->rx_chan' and 'nvme_epf->tx_chan' and instead of the local
variable 'chan'.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
Changes from v1:
* Refer to nvme_epf->dma_[rt]x_chan and do not move the dev_dbg() call

 drivers/nvme/target/pci-epf.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c
index 2e78397a7373..4bfecb0c7ee4 100644
--- a/drivers/nvme/target/pci-epf.c
+++ b/drivers/nvme/target/pci-epf.c
@@ -320,12 +320,14 @@ static void nvmet_pci_epf_init_dma(struct nvmet_pci_epf *nvme_epf)
 	nvme_epf->dma_enabled = true;
 
 	dev_dbg(dev, "Using DMA RX channel %s, maximum segment size %u B\n",
-		dma_chan_name(chan),
-		dma_get_max_seg_size(dmaengine_get_dma_device(chan)));
+		dma_chan_name(nvme_epf->dma_rx_chan),
+		dma_get_max_seg_size(dmaengine_get_dma_device(nvme_epf->
+							      dma_rx_chan)));
 
 	dev_dbg(dev, "Using DMA TX channel %s, maximum segment size %u B\n",
-		dma_chan_name(chan),
-		dma_get_max_seg_size(dmaengine_get_dma_device(chan)));
+		dma_chan_name(nvme_epf->dma_tx_chan),
+		dma_get_max_seg_size(dmaengine_get_dma_device(nvme_epf->
+							      dma_tx_chan)));
 
 	return;
 
-- 
2.51.0

Re: [PATCH v2] nvmet: pci-epf: fix DMA channel debug print

[Damien Le Moal]

On 9/13/25 15:53, Shin'ichiro Kawasaki wrote:
> Currently, nvmet_pci_epf_init_dma() has two dev_dbg() calls intended to
> print debug information about the DMA channels for RX and TX. However,
> both calls mistakenly are made for the TX channel. Fix it by referreing
> to 'nvme_epf->rx_chan' and 'nvme_epf->tx_chan' and instead of the local
> variable 'chan'.
> 
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH v2] nvmet: pci-epf: fix DMA channel debug print

[Niklas Cassel]

On Sat, Sep 13, 2025 at 03:53:50PM +0900, Shin'ichiro Kawasaki wrote:
> Currently, nvmet_pci_epf_init_dma() has two dev_dbg() calls intended to
> print debug information about the DMA channels for RX and TX. However,
> both calls mistakenly are made for the TX channel. Fix it by referreing
> to 'nvme_epf->rx_chan' and 'nvme_epf->tx_chan' and instead of the local
> variable 'chan'.
> 
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
> Changes from v1:
> * Refer to nvme_epf->dma_[rt]x_chan and do not move the dev_dbg() call
> 
>  drivers/nvme/target/pci-epf.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c
> index 2e78397a7373..4bfecb0c7ee4 100644
> --- a/drivers/nvme/target/pci-epf.c
> +++ b/drivers/nvme/target/pci-epf.c
> @@ -320,12 +320,14 @@ static void nvmet_pci_epf_init_dma(struct nvmet_pci_epf *nvme_epf)
>  	nvme_epf->dma_enabled = true;
>  
>  	dev_dbg(dev, "Using DMA RX channel %s, maximum segment size %u B\n",
> -		dma_chan_name(chan),
> -		dma_get_max_seg_size(dmaengine_get_dma_device(chan)));
> +		dma_chan_name(nvme_epf->dma_rx_chan),
> +		dma_get_max_seg_size(dmaengine_get_dma_device(nvme_epf->
> +							      dma_rx_chan)));
>  
>  	dev_dbg(dev, "Using DMA TX channel %s, maximum segment size %u B\n",
> -		dma_chan_name(chan),
> -		dma_get_max_seg_size(dmaengine_get_dma_device(chan)));
> +		dma_chan_name(nvme_epf->dma_tx_chan),
> +		dma_get_max_seg_size(dmaengine_get_dma_device(nvme_epf->
> +							      dma_tx_chan)));
>  
>  	return;
>  
> -- 
> 2.51.0

Gentle ping


Kind regards,
Niklas

Re: [PATCH v2] nvmet: pci-epf: fix DMA channel debug print

[Keith Busch]

On Sat, Sep 13, 2025 at 03:53:50PM +0900, Shin'ichiro Kawasaki wrote:
> Currently, nvmet_pci_epf_init_dma() has two dev_dbg() calls intended to
> print debug information about the DMA channels for RX and TX. However,
> both calls mistakenly are made for the TX channel. Fix it by referreing
> to 'nvme_epf->rx_chan' and 'nvme_epf->tx_chan' and instead of the local
> variable 'chan'.

Thanks, applied to nvme-6.19.