From: james.smart@broadcom.com (James Smart)
Subject: "nvme-cli : wrong connection string for /dev/nvme-facrics (FC)"
Date: Mon, 4 Feb 2019 13:41:04 -0800 [thread overview]
Message-ID: <7b8e7f70-d520-2a64-ba5b-636dc033fe04@broadcom.com> (raw)
In-Reply-To: <CAPrnrPC_8aM2mc17gU=FvM2TMC+oFvMQGJW4svOBCrZwfC09Yg@mail.gmail.com>
Eyal,
Yes, that patch switched things up on FC and made it no longer match the
fc transport.
I just submitted a patch to correct it.
Thank You
-- james
On 2/3/2019 7:36 AM, Eyal BenDavid wrote:
> Hi all,
>
> I tried latest nvme-cli with FC and kept getting "invalid argument"
> from nvme-fabrics.
>
> I added a print of the connection string.
>
> The connection string is probably wrong (or it can't work with older kernels)
>
> The transport arg in the conn string is "...,transport=fibre-channel,..."
>
> I think it should be "fc" and not "fibre-channel"
>
> dmesg says: [515366.391531] nvme_fabrics: no handler found for
> transport fibre-channel
>
> The commit that removed explicit "transport=fc" is:
>
> commit 55b4ec12ffe43c5abd78fa5806fd2141b49aa1db
> Author: Sagi Grimberg <sagi at grimberg.me>
> Date: Tue Nov 20 13:26:06 2018 -0800
>
> fabrics: use trtype_str when parsing a discovery log entry
>
> Reduce some code duplication.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
>
>
> Thanks
> Eyal
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-02-04 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 15:36 "nvme-cli : wrong connection string for /dev/nvme-facrics (FC)" Eyal BenDavid
2019-02-04 21:41 ` James Smart [this message]
2019-02-04 21:48 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8e7f70-d520-2a64-ba5b-636dc033fe04@broadcom.com \
--to=james.smart@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox