* "nvme-cli : wrong connection string for /dev/nvme-facrics (FC)"
@ 2019-02-03 15:36 Eyal BenDavid
2019-02-04 21:41 ` James Smart
0 siblings, 1 reply; 3+ messages in thread
From: Eyal BenDavid @ 2019-02-03 15:36 UTC (permalink / raw)
Hi all,
I tried latest nvme-cli with FC and kept getting "invalid argument"
from nvme-fabrics.
I added a print of the connection string.
The connection string is probably wrong (or it can't work with older kernels)
The transport arg in the conn string is "...,transport=fibre-channel,..."
I think it should be "fc" and not "fibre-channel"
dmesg says: [515366.391531] nvme_fabrics: no handler found for
transport fibre-channel
The commit that removed explicit "transport=fc" is:
commit 55b4ec12ffe43c5abd78fa5806fd2141b49aa1db
Author: Sagi Grimberg <sagi at grimberg.me>
Date: Tue Nov 20 13:26:06 2018 -0800
fabrics: use trtype_str when parsing a discovery log entry
Reduce some code duplication.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Thanks
Eyal
^ permalink raw reply [flat|nested] 3+ messages in thread* "nvme-cli : wrong connection string for /dev/nvme-facrics (FC)"
2019-02-03 15:36 "nvme-cli : wrong connection string for /dev/nvme-facrics (FC)" Eyal BenDavid
@ 2019-02-04 21:41 ` James Smart
2019-02-04 21:48 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: James Smart @ 2019-02-04 21:41 UTC (permalink / raw)
Eyal,
Yes, that patch switched things up on FC and made it no longer match the
fc transport.
I just submitted a patch to correct it.
Thank You
-- james
On 2/3/2019 7:36 AM, Eyal BenDavid wrote:
> Hi all,
>
> I tried latest nvme-cli with FC and kept getting "invalid argument"
> from nvme-fabrics.
>
> I added a print of the connection string.
>
> The connection string is probably wrong (or it can't work with older kernels)
>
> The transport arg in the conn string is "...,transport=fibre-channel,..."
>
> I think it should be "fc" and not "fibre-channel"
>
> dmesg says: [515366.391531] nvme_fabrics: no handler found for
> transport fibre-channel
>
> The commit that removed explicit "transport=fc" is:
>
> commit 55b4ec12ffe43c5abd78fa5806fd2141b49aa1db
> Author: Sagi Grimberg <sagi at grimberg.me>
> Date: Tue Nov 20 13:26:06 2018 -0800
>
> fabrics: use trtype_str when parsing a discovery log entry
>
> Reduce some code duplication.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
>
>
> Thanks
> Eyal
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-04 21:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-03 15:36 "nvme-cli : wrong connection string for /dev/nvme-facrics (FC)" Eyal BenDavid
2019-02-04 21:41 ` James Smart
2019-02-04 21:48 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox