public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Claus Stovgaard <claus.stovgaard@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org
Subject: Re: Missing or invalid SUBNQN on Corsair MP600 1TB device
Date: Mon, 01 Feb 2021 22:22:21 +0100	[thread overview]
Message-ID: <7dce6c69b48d97b467bb558c3d13ec134d44964b.camel@gmail.com> (raw)
In-Reply-To: <20210125175827.GA1732047@dhcp-10-100-145-180.wdc.com>

On Mon, 2021-01-25 at 09:58 -0800, Keith Busch wrote:
> On Mon, Jan 25, 2021 at 05:00:57PM +0100, Claus Stovgaard wrote:
> > So I guess that Corsair MP600 is a candidate for the same quirk.
> > 
> > Considered to add the Corsair to the list of drives with
> > NVME_QUIRK_IGNORE_DEV_SUBNQN, but would just ask here first, if it
> > would be the correct use and understanding.
> 
> Yes, that is the correct quirk to use with devices reporting spec
> revision 1.2.1 compatibility but are not compliant with the subsys
> nqn
> field. The device should continue to work without the quirk, but
> you'll
> get the warning.

Thanks for the reply Keith. I have just created a patch with this quirk
for the Phison E16 (Corsair MP600). Being a simple change, I figured it
was a good start for novice in submitting kernel patches.

Regards
Claus


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply	other threads:[~2021-02-01 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 16:00 Missing or invalid SUBNQN on Corsair MP600 1TB device Claus Stovgaard
2021-01-25 17:58 ` Keith Busch
2021-02-01 21:22   ` Claus Stovgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dce6c69b48d97b467bb558c3d13ec134d44964b.camel@gmail.com \
    --to=claus.stovgaard@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox