Missing or invalid SUBNQN on Corsair MP600 1TB device

Missing or invalid SUBNQN on Corsair MP600 1TB device

[Claus Stovgaard]

Hi

This is my first post to this mailing list, so please forgive me if it
is already discussed.

I have just build a new workstation, where I noticed the following
warning for the Corsair MP600 1 TB drive.

nvme nvme0: missing or invalid SUBNQN field.

it arrived with firmware 11.3 and I have later upgraded to firmware
13.0 to see if they have fixed the firmware.

Have also reported in their forum
https://forum.corsair.com/forums/showthread.php?p=1077109#post1077109

Looking in the host pci.c code it seems to be a known issue on some
drives where the "NVME_QUIRK_IGNORE_DEV_SUBNQN" is used.

So I guess that Corsair MP600 is a candidate for the same quirk.

Considered to add the Corsair to the list of drives with
NVME_QUIRK_IGNORE_DEV_SUBNQN, but would just ask here first, if it
would be the correct use and understanding.

Regards Claus

Below is info for my system for reference.

nova /home/frosteyes # uname -a
Linux nova 5.10.10-gentoo-FrostEyes #1 SMP PREEMPT Sun Jan 24 23:26:32
CET 2021 x86_64 AMD Ryzen 9 5950X 16-Core Processor AuthenticAMD
GNU/Linux

nova /home/frosteyes # journalctl -b | grep nvme0
jan 24 23:32:23 nova kernel: nvme nvme0: pci function 0000:01:00.0
jan 24 23:32:23 nova kernel: nvme nvme0: missing or invalid SUBNQN
field.
jan 24 23:32:23 nova kernel: nvme nvme0: Shutdown timeout set to 10
seconds
jan 24 23:32:23 nova kernel: nvme nvme0: 8/0/0 default/read/poll queues
jan 24 23:32:23 nova kernel:  nvme0n1: p1 p2

nova /home/frosteyes # nvme list
Node             SN                   Model                            
        Namespace Usage                      Format           FW Rev  
---------------- -------------------- -------------------------------
--------- --------- -------------------------- ---------------- -----
---
/dev/nvme0n1     203982290001285542EC Force
MP600                              1           1,00  TB
/   1,00  TB    512   B +  0 B   EGFM13.0

nova /home/frosteyes # lspci -v -nn -s 1:00
01:00.0 Non-Volatile memory controller [0108]: Phison Electronics
Corporation E16 PCIe4 NVMe Controller [1987:5016] (rev 01) (prog-if 02
[NVM Express])
        Subsystem: Phison Electronics Corporation E16 PCIe4 NVMe
Controller [1987:5016]
        Flags: bus master, fast devsel, latency 0, IRQ 42, NUMA node 0
        Memory at fcf00000 (64-bit, non-prefetchable) [size=16K]
        Capabilities: [80] Express Endpoint, MSI 00
        Capabilities: [d0] MSI-X: Enable+ Count=9 Masked-
        Capabilities: [e0] MSI: Enable- Count=1/8 Maskable- 64bit+
        Capabilities: [f8] Power Management version 3
        Capabilities: [100] Latency Tolerance Reporting
        Capabilities: [110] L1 PM Substates
        Capabilities: [128] Alternative Routing-ID Interpretation (ARI)
        Capabilities: [1e0] Data Link Feature <?>
        Capabilities: [200] Advanced Error Reporting
        Capabilities: [300] Secondary PCI Express
        Capabilities: [340] Physical Layer 16.0 GT/s <?>
        Capabilities: [378] Lane Margining at the Receiver <?>
        Kernel driver in use: nvme


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: Missing or invalid SUBNQN on Corsair MP600 1TB device

[Keith Busch]

On Mon, Jan 25, 2021 at 05:00:57PM +0100, Claus Stovgaard wrote:
> I have just build a new workstation, where I noticed the following
> warning for the Corsair MP600 1 TB drive.
> 
> nvme nvme0: missing or invalid SUBNQN field.
> 
> it arrived with firmware 11.3 and I have later upgraded to firmware
> 13.0 to see if they have fixed the firmware.
> 
> Have also reported in their forum
> https://forum.corsair.com/forums/showthread.php?p=1077109#post1077109
> 
> Looking in the host pci.c code it seems to be a known issue on some
> drives where the "NVME_QUIRK_IGNORE_DEV_SUBNQN" is used.
> 
> So I guess that Corsair MP600 is a candidate for the same quirk.
> 
> Considered to add the Corsair to the list of drives with
> NVME_QUIRK_IGNORE_DEV_SUBNQN, but would just ask here first, if it
> would be the correct use and understanding.

Yes, that is the correct quirk to use with devices reporting spec
revision 1.2.1 compatibility but are not compliant with the subsys nqn
field. The device should continue to work without the quirk, but you'll
get the warning.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: Missing or invalid SUBNQN on Corsair MP600 1TB device

[Claus Stovgaard]

On Mon, 2021-01-25 at 09:58 -0800, Keith Busch wrote:
> On Mon, Jan 25, 2021 at 05:00:57PM +0100, Claus Stovgaard wrote:
> > So I guess that Corsair MP600 is a candidate for the same quirk.
> > 
> > Considered to add the Corsair to the list of drives with
> > NVME_QUIRK_IGNORE_DEV_SUBNQN, but would just ask here first, if it
> > would be the correct use and understanding.
> 
> Yes, that is the correct quirk to use with devices reporting spec
> revision 1.2.1 compatibility but are not compliant with the subsys
> nqn
> field. The device should continue to work without the quirk, but
> you'll
> get the warning.

Thanks for the reply Keith. I have just created a patch with this quirk
for the Phison E16 (Corsair MP600). Being a simple change, I figured it
was a good start for novice in submitting kernel patches.

Regards
Claus


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme