Re: [PATCH blktests] nvme: add dh module requirement for tests that involve dh groups

[Jackie Liu <liu.yun@linux.dev>]

My fault, my config file becomes y because NVME_CORE is also y.
sorry to bother you.

-- 
Jackie Liu

在 2022/8/30 15:37, Sagi Grimberg 写道:
> 
>> Hi Sagi.
>>
>> 在 2022/8/30 15:05, Sagi Grimberg 写道:
>>>
>>>> Hi Sagi,
>>>>
>>>> On Aug 29, 2022 / 11:36, Sagi Grimberg wrote:
>>>>> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
>>>>> ---
>>>>>   tests/nvme/043 | 1 +
>>>>>   tests/nvme/044 | 1 +
>>>>>   tests/nvme/045 | 1 +
>>>>>   3 files changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/tests/nvme/043 b/tests/nvme/043
>>>>> index 381ae755f140..87273e5b414d 100755
>>>>> --- a/tests/nvme/043
>>>>> +++ b/tests/nvme/043
>>>>> @@ -16,6 +16,7 @@ requires() {
>>>>>       _have_kernel_option NVME_TARGET_AUTH
>>>>>       _require_nvme_trtype_is_fabrics
>>>>>       _require_nvme_cli_auth
>>>>> +    _have_driver dh_generic
>>>>>   }
>>>>
>>>> Do you see failure without this check?
>>>
>>> Yes, if dh_generic is built as a module (CONFIG_CRYPTO_DH=m).
>>
>> Maybe I don't understand correctly, but I think when NVME_AUTH=y
>> CONFIG_CRYPTO_DH can only be built in.
>>
> 
> No.
> 
> In my .config:
> -- 
> ...
> #
> # NVME Support
> #
> CONFIG_NVME_COMMON=m
> CONFIG_NVME_CORE=m
> CONFIG_BLK_DEV_NVME=m
> CONFIG_NVME_MULTIPATH=y
> # CONFIG_NVME_VERBOSE_ERRORS is not set
> CONFIG_NVME_HWMON=y
> CONFIG_NVME_FABRICS=m
> CONFIG_NVME_RDMA=m
> CONFIG_NVME_FC=m
> CONFIG_NVME_TCP=m
> CONFIG_NVME_AUTH=y
> CONFIG_NVME_TARGET=m
> CONFIG_NVME_TARGET_PASSTHRU=y
> CONFIG_NVME_TARGET_LOOP=m
> CONFIG_NVME_TARGET_RDMA=m
> CONFIG_NVME_TARGET_FC=m
> CONFIG_NVME_TARGET_FCLOOP=m
> CONFIG_NVME_TARGET_TCP=m
> CONFIG_NVME_TARGET_AUTH=y
> # end of NVME Support
> ...
> #
> # Public-key cryptography
> #
> CONFIG_CRYPTO_RSA=y
> CONFIG_CRYPTO_DH=m
> CONFIG_CRYPTO_DH_RFC7919_GROUPS=y
> CONFIG_CRYPTO_ECC=m
> CONFIG_CRYPTO_ECDH=m
> # CONFIG_CRYPTO_ECDSA is not set
> # CONFIG_CRYPTO_ECRDSA is not set
> # CONFIG_CRYPTO_SM2 is not set
> # CONFIG_CRYPTO_CURVE25519 is not set
> # CONFIG_CRYPTO_CURVE25519_X86 is not set
> --