Re: [PATCH blktests] nvme: add dh module requirement for tests that involve dh groups

[Jackie Liu <liu.yun@linux.dev>]

Hi Sagi.

在 2022/8/30 15:05, Sagi Grimberg 写道:
> 
>> Hi Sagi,
>>
>> On Aug 29, 2022 / 11:36, Sagi Grimberg wrote:
>>> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
>>> ---
>>>   tests/nvme/043 | 1 +
>>>   tests/nvme/044 | 1 +
>>>   tests/nvme/045 | 1 +
>>>   3 files changed, 3 insertions(+)
>>>
>>> diff --git a/tests/nvme/043 b/tests/nvme/043
>>> index 381ae755f140..87273e5b414d 100755
>>> --- a/tests/nvme/043
>>> +++ b/tests/nvme/043
>>> @@ -16,6 +16,7 @@ requires() {
>>>       _have_kernel_option NVME_TARGET_AUTH
>>>       _require_nvme_trtype_is_fabrics
>>>       _require_nvme_cli_auth
>>> +    _have_driver dh_generic
>>>   }
>>
>> Do you see failure without this check?
> 
> Yes, if dh_generic is built as a module (CONFIG_CRYPTO_DH=m).

Maybe I don't understand correctly, but I think when NVME_AUTH=y
CONFIG_CRYPTO_DH can only be built in.

-- 
Jackie Liu