From: John Garry <john.g.garry@oracle.com>
To: Nilay Shroff <nilay@linux.ibm.com>,
hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: make some sysfs diagnostic structures static
Date: Wed, 10 Jun 2026 10:28:44 +0100 [thread overview]
Message-ID: <8230e53e-dd29-474d-ac8e-2af2b49cf459@oracle.com> (raw)
In-Reply-To: <6f7fee87-8d2b-472e-94a6-150c25c0465f@linux.ibm.com>
>> }
>> -struct device_attribute dev_attr_adm_errors =
>> +static struct device_attribute dev_attr_adm_errors =
>> __ATTR(command_error_count, 0644,
>> nvme_adm_errors_show, nvme_adm_errors_store);
> BTW, kernel test robot also reported this same issue here:
> https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-
> all/202606101329.T3zXNqdy-lkp@intel.com/__;!!ACWV5N9M2RV99hQ!
> P5UdkxQBbB6XuNloxfIJKNALsPKk8vSXQENG4khm-
> SufSw1QG_Ndga5ZvcKhtCypHWJDcNkaE1KDvZZ8pO8$
> So you may want to add closes tag pointing to the above link. Otherwise,
> this change looks good to me.
>
I would not have noticed that, but here is the necessary tag anyway:
Closes:
https://lore.kernel.org/oe-kbuild-all/202606101329.T3zXNqdy-lkp@intel.com/
> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
Cheers
next prev parent reply other threads:[~2026-06-10 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 8:53 [PATCH] nvme: make some sysfs diagnostic structures static John Garry
2026-06-10 9:11 ` Nilay Shroff
2026-06-10 9:28 ` John Garry [this message]
2026-06-10 11:57 ` Christoph Hellwig
2026-06-10 14:31 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8230e53e-dd29-474d-ac8e-2af2b49cf459@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox