From: Keith Busch <kbusch@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: hch@lst.de, sagi@grimberg.me, axboe@fb.com,
linux-nvme@lists.infradead.org, nilay@linux.ibm.com
Subject: Re: [PATCH] nvme: make some sysfs diagnostic structures static
Date: Wed, 10 Jun 2026 08:31:39 -0600 [thread overview]
Message-ID: <ail1S6BlIlJ2jxsn@kbusch-mbp> (raw)
In-Reply-To: <20260610085332.3213760-1-john.g.garry@oracle.com>
On Wed, Jun 10, 2026 at 08:53:32AM +0000, John Garry wrote:
> Building with C=1 generates the following warnings:
> drivers/nvme/host/sysfs.c:397:25: warning: symbol 'dev_attr_io_errors' was not declared. Should it be static?
> drivers/nvme/host/sysfs.c:444:30: warning: symbol 'nvme_ns_diag_attr_group' was not declared. Should it be static?
> drivers/nvme/host/sysfs.c:1150:25: warning: symbol 'dev_attr_adm_errors' was not declared. Should it be static?
>
> Make those structures static.
Thanks, applied to nvme-7.2.
prev parent reply other threads:[~2026-06-10 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 8:53 [PATCH] nvme: make some sysfs diagnostic structures static John Garry
2026-06-10 9:11 ` Nilay Shroff
2026-06-10 9:28 ` John Garry
2026-06-10 11:57 ` Christoph Hellwig
2026-06-10 14:31 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ail1S6BlIlJ2jxsn@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox