* [PATCH 1/2] nvme: add module description to stop warnings
@ 2024-01-18 5:36 Chaitanya Kulkarni
2024-01-18 5:36 ` [PATCH 2/2] nvmet: " Chaitanya Kulkarni
2024-01-18 12:24 ` [PATCH 1/2] nvme: " Sagi Grimberg
0 siblings, 2 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2024-01-18 5:36 UTC (permalink / raw)
To: linux-nvme; +Cc: kbusch, hch, sagi, james.smart, Chaitanya Kulkarni
Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fabrics.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-rdma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fc.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-tcp.o
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvme/host/core.c | 1 +
drivers/nvme/host/fabrics.c | 1 +
drivers/nvme/host/fc.c | 1 +
drivers/nvme/host/pci.c | 1 +
drivers/nvme/host/rdma.c | 1 +
drivers/nvme/host/tcp.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 8971af7fcb2b..fa14e16731c0 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4856,5 +4856,6 @@ static void __exit nvme_core_exit(void)
MODULE_LICENSE("GPL");
MODULE_VERSION("1.0");
+MODULE_DESCRIPTION("Essential NVMe Host core functionality");
module_init(nvme_core_init);
module_exit(nvme_core_exit);
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index aa88606a44c4..ed2fd0a0d688 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -1488,6 +1488,7 @@ static void __exit nvmf_exit(void)
}
MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Essential NVMeOF Host core functionality");
module_init(nvmf_init);
module_exit(nvmf_exit);
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 05c3159d42e9..522319a4d6f2 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -4015,4 +4015,5 @@ static void __exit nvme_fc_exit_module(void)
module_init(nvme_fc_init_module);
module_exit(nvme_fc_exit_module);
+MODULE_DESCRIPTION("NVMeOF Host FC transport");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 46d3897b8986..9801dbe09dad 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3529,5 +3529,6 @@ static void __exit nvme_exit(void)
MODULE_AUTHOR("Matthew Wilcox <willy@linux.intel.com>");
MODULE_LICENSE("GPL");
MODULE_VERSION("1.0");
+MODULE_DESCRIPTION("NVMe PCIe transport");
module_init(nvme_init);
module_exit(nvme_exit);
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 2e77c0f25f71..d93c863d036d 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -2395,4 +2395,5 @@ static void __exit nvme_rdma_cleanup_module(void)
module_init(nvme_rdma_init_module);
module_exit(nvme_rdma_cleanup_module);
+MODULE_DESCRIPTION("NVMeOF Host RDMA transport");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index b234f0674aeb..016a3b7c0791 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2819,4 +2819,5 @@ static void __exit nvme_tcp_cleanup_module(void)
module_init(nvme_tcp_init_module);
module_exit(nvme_tcp_cleanup_module);
+MODULE_DESCRIPTION("NVMeOF Host TCP transport");
MODULE_LICENSE("GPL v2");
--
2.40.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] nvmet: add module description to stop warnings
2024-01-18 5:36 [PATCH 1/2] nvme: add module description to stop warnings Chaitanya Kulkarni
@ 2024-01-18 5:36 ` Chaitanya Kulkarni
2024-01-18 12:26 ` Sagi Grimberg
2024-01-18 12:24 ` [PATCH 1/2] nvme: " Sagi Grimberg
1 sibling, 1 reply; 5+ messages in thread
From: Chaitanya Kulkarni @ 2024-01-18 5:36 UTC (permalink / raw)
To: linux-nvme; +Cc: kbusch, hch, sagi, james.smart, Chaitanya Kulkarni
Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-loop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-rdma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-fc.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-fcloop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-tcp.o
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvme/target/core.c | 1 +
drivers/nvme/target/fc.c | 1 +
drivers/nvme/target/fcloop.c | 1 +
drivers/nvme/target/loop.c | 1 +
drivers/nvme/target/rdma.c | 1 +
drivers/nvme/target/tcp.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index d26aa30f8702..5192f4d71243 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -1705,4 +1705,5 @@ static void __exit nvmet_exit(void)
module_init(nvmet_init);
module_exit(nvmet_exit);
+MODULE_DESCRIPTION("Essential NVMeOF Target core functionality");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index bda7a3009e85..f72f912fc1de 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -2945,4 +2945,5 @@ static void __exit nvmet_fc_exit_module(void)
module_init(nvmet_fc_init_module);
module_exit(nvmet_fc_exit_module);
+MODULE_DESCRIPTION("NVMeOF Target FC transport");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c
index ead349af30f1..49fd1f7380dd 100644
--- a/drivers/nvme/target/fcloop.c
+++ b/drivers/nvme/target/fcloop.c
@@ -1650,4 +1650,5 @@ static void __exit fcloop_exit(void)
module_init(fcloop_init);
module_exit(fcloop_exit);
+MODULE_DESCRIPTION("NVMeOF FC loopback transport");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 9cb434c58075..35b1ff0cf16b 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -688,5 +688,6 @@ static void __exit nvme_loop_cleanup_module(void)
module_init(nvme_loop_init_module);
module_exit(nvme_loop_cleanup_module);
+MODULE_DESCRIPTION("NVMeOF loopback transport");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("nvmet-transport-254"); /* 254 == NVMF_TRTYPE_LOOP */
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 667f9c04f35d..f7e1ac6ed3ad 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -2104,5 +2104,6 @@ static void __exit nvmet_rdma_exit(void)
module_init(nvmet_rdma_init);
module_exit(nvmet_rdma_exit);
+MODULE_DESCRIPTION("NVMeOF Target RDMA transport");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("nvmet-transport-1"); /* 1 == NVMF_TRTYPE_RDMA */
diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
index 6a1e6bb80062..1f3ea988b671 100644
--- a/drivers/nvme/target/tcp.c
+++ b/drivers/nvme/target/tcp.c
@@ -2221,5 +2221,6 @@ static void __exit nvmet_tcp_exit(void)
module_init(nvmet_tcp_init);
module_exit(nvmet_tcp_exit);
+MODULE_DESCRIPTION("NVMeOF Target TCP transport");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("nvmet-transport-3"); /* 3 == NVMF_TRTYPE_TCP */
--
2.40.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] nvme: add module description to stop warnings
2024-01-18 5:36 [PATCH 1/2] nvme: add module description to stop warnings Chaitanya Kulkarni
2024-01-18 5:36 ` [PATCH 2/2] nvmet: " Chaitanya Kulkarni
@ 2024-01-18 12:24 ` Sagi Grimberg
1 sibling, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2024-01-18 12:24 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-nvme; +Cc: kbusch, hch, james.smart
On 1/18/24 07:36, Chaitanya Kulkarni wrote:
> Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-core.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fabrics.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-rdma.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fc.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-tcp.o
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/nvme/host/core.c | 1 +
> drivers/nvme/host/fabrics.c | 1 +
> drivers/nvme/host/fc.c | 1 +
> drivers/nvme/host/pci.c | 1 +
> drivers/nvme/host/rdma.c | 1 +
> drivers/nvme/host/tcp.c | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 8971af7fcb2b..fa14e16731c0 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -4856,5 +4856,6 @@ static void __exit nvme_core_exit(void)
>
> MODULE_LICENSE("GPL");
> MODULE_VERSION("1.0");
> +MODULE_DESCRIPTION("Essential NVMe Host core functionality");
NVMe host core framework ?
> module_init(nvme_core_init);
> module_exit(nvme_core_exit);
> diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
> index aa88606a44c4..ed2fd0a0d688 100644
> --- a/drivers/nvme/host/fabrics.c
> +++ b/drivers/nvme/host/fabrics.c
> @@ -1488,6 +1488,7 @@ static void __exit nvmf_exit(void)
> }
>
> MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Essential NVMeOF Host core functionality");
NVMe host fabrics library
>
> module_init(nvmf_init);
> module_exit(nvmf_exit);
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index 05c3159d42e9..522319a4d6f2 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -4015,4 +4015,5 @@ static void __exit nvme_fc_exit_module(void)
> module_init(nvme_fc_init_module);
> module_exit(nvme_fc_exit_module);
>
> +MODULE_DESCRIPTION("NVMeOF Host FC transport");
NVMe host FC transport driver ?
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 46d3897b8986..9801dbe09dad 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3529,5 +3529,6 @@ static void __exit nvme_exit(void)
> MODULE_AUTHOR("Matthew Wilcox <willy@linux.intel.com>");
> MODULE_LICENSE("GPL");
> MODULE_VERSION("1.0");
> +MODULE_DESCRIPTION("NVMe PCIe transport");
NVMe host PCIe transport driver
> module_init(nvme_init);
> module_exit(nvme_exit);
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 2e77c0f25f71..d93c863d036d 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -2395,4 +2395,5 @@ static void __exit nvme_rdma_cleanup_module(void)
> module_init(nvme_rdma_init_module);
> module_exit(nvme_rdma_cleanup_module);
>
> +MODULE_DESCRIPTION("NVMeOF Host RDMA transport");
NVMe host RDMA transport driver
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
> index b234f0674aeb..016a3b7c0791 100644
> --- a/drivers/nvme/host/tcp.c
> +++ b/drivers/nvme/host/tcp.c
> @@ -2819,4 +2819,5 @@ static void __exit nvme_tcp_cleanup_module(void)
> module_init(nvme_tcp_init_module);
> module_exit(nvme_tcp_cleanup_module);
>
> +MODULE_DESCRIPTION("NVMeOF Host TCP transport");
NVMe host TCP transport driver ?
> MODULE_LICENSE("GPL v2");
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] nvmet: add module description to stop warnings
2024-01-18 5:36 ` [PATCH 2/2] nvmet: " Chaitanya Kulkarni
@ 2024-01-18 12:26 ` Sagi Grimberg
2024-01-18 18:28 ` Chaitanya Kulkarni
0 siblings, 1 reply; 5+ messages in thread
From: Sagi Grimberg @ 2024-01-18 12:26 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-nvme; +Cc: kbusch, hch, james.smart
On 1/18/24 07:36, Chaitanya Kulkarni wrote:
> Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-loop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-rdma.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-fc.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-fcloop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-tcp.o
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/nvme/target/core.c | 1 +
> drivers/nvme/target/fc.c | 1 +
> drivers/nvme/target/fcloop.c | 1 +
> drivers/nvme/target/loop.c | 1 +
> drivers/nvme/target/rdma.c | 1 +
> drivers/nvme/target/tcp.c | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
> index d26aa30f8702..5192f4d71243 100644
> --- a/drivers/nvme/target/core.c
> +++ b/drivers/nvme/target/core.c
> @@ -1705,4 +1705,5 @@ static void __exit nvmet_exit(void)
> module_init(nvmet_init);
> module_exit(nvmet_exit);
>
> +MODULE_DESCRIPTION("Essential NVMeOF Target core functionality");
NVMe target core framework ?
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
> index bda7a3009e85..f72f912fc1de 100644
> --- a/drivers/nvme/target/fc.c
> +++ b/drivers/nvme/target/fc.c
> @@ -2945,4 +2945,5 @@ static void __exit nvmet_fc_exit_module(void)
> module_init(nvmet_fc_init_module);
> module_exit(nvmet_fc_exit_module);
>
> +MODULE_DESCRIPTION("NVMeOF Target FC transport");
NVMe target FC transport driver ?
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c
> index ead349af30f1..49fd1f7380dd 100644
> --- a/drivers/nvme/target/fcloop.c
> +++ b/drivers/nvme/target/fcloop.c
> @@ -1650,4 +1650,5 @@ static void __exit fcloop_exit(void)
> module_init(fcloop_init);
> module_exit(fcloop_exit);
>
> +MODULE_DESCRIPTION("NVMeOF FC loopback transport");
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
> index 9cb434c58075..35b1ff0cf16b 100644
> --- a/drivers/nvme/target/loop.c
> +++ b/drivers/nvme/target/loop.c
> @@ -688,5 +688,6 @@ static void __exit nvme_loop_cleanup_module(void)
> module_init(nvme_loop_init_module);
> module_exit(nvme_loop_cleanup_module);
>
> +MODULE_DESCRIPTION("NVMeOF loopback transport");
NVMe target loop transport driver ?
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("nvmet-transport-254"); /* 254 == NVMF_TRTYPE_LOOP */
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index 667f9c04f35d..f7e1ac6ed3ad 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -2104,5 +2104,6 @@ static void __exit nvmet_rdma_exit(void)
> module_init(nvmet_rdma_init);
> module_exit(nvmet_rdma_exit);
>
> +MODULE_DESCRIPTION("NVMeOF Target RDMA transport");
NVMe target RDMA transport driver ?
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("nvmet-transport-1"); /* 1 == NVMF_TRTYPE_RDMA */
> diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
> index 6a1e6bb80062..1f3ea988b671 100644
> --- a/drivers/nvme/target/tcp.c
> +++ b/drivers/nvme/target/tcp.c
> @@ -2221,5 +2221,6 @@ static void __exit nvmet_tcp_exit(void)
> module_init(nvmet_tcp_init);
> module_exit(nvmet_tcp_exit);
>
> +MODULE_DESCRIPTION("NVMeOF Target TCP transport");
NVMe target TCP transport target ?
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("nvmet-transport-3"); /* 3 == NVMF_TRTYPE_TCP */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] nvmet: add module description to stop warnings
2024-01-18 12:26 ` Sagi Grimberg
@ 2024-01-18 18:28 ` Chaitanya Kulkarni
0 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2024-01-18 18:28 UTC (permalink / raw)
To: Sagi Grimberg
Cc: kbusch@kernel.org, hch@lst.de, james.smart@broadcom.com,
linux-nvme@lists.infradead.org, Chaitanya Kulkarni
> NVMe target TCP transport target ?
>
>> MODULE_LICENSE("GPL v2");
>> MODULE_ALIAS("nvmet-transport-3"); /* 3 == NVMF_TRTYPE_TCP */
>
will send out V2 with your suggestions ...
-ck
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-18 18:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-18 5:36 [PATCH 1/2] nvme: add module description to stop warnings Chaitanya Kulkarni
2024-01-18 5:36 ` [PATCH 2/2] nvmet: " Chaitanya Kulkarni
2024-01-18 12:26 ` Sagi Grimberg
2024-01-18 18:28 ` Chaitanya Kulkarni
2024-01-18 12:24 ` [PATCH 1/2] nvme: " Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox