Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: rosattig@linux.vnet.ibm.com (Rodrigo Rosatti Galvão)
Subject: [PATCH] nvmet: fix nvmet_execute_write_zeroes function
Date: Fri, 30 Mar 2018 18:48:18 -0300	[thread overview]
Message-ID: <93622938-f532-b8ac-2bca-fe40ed759e71@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180330212439.GA28945@localhost.localdomain>


> Doesn't that mean your host is using this command wrong? The NLB is a
> 0's based value, we're supposed to +1 to get the correct block count.

Keith, I tested passing different values to the c (number of blocks) and 
s (64-bit LBA of first block to access) parameters, and it was failing. 
When I removed the +1, the command worked fine.

I used a simple script to validate this:

for s in {0..20}
 ??? do
 ??? ??? ??? for c in {0..20}
 ??? ??? ??? do
 ??? ??? ??????????? nvme write-zeroes /dev/nvme0 -n 10 -s $s -c $c
 ??? ??? ??? done
 ??? done


Is there some other way to test it?

-- 
Rodrigo R. Galv?o
Intern - Linux Technology Center - IBM

  reply	other threads:[~2018-03-30 21:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 21:18 [PATCH] nvmet: fix nvmet_execute_write_zeroes function Rodrigo R. Galvao
2018-03-30 21:24 ` Keith Busch
2018-03-30 21:48   ` Rodrigo Rosatti Galvão [this message]
2018-04-02  8:03     ` chaitany kulkarni
2018-04-02 13:47       ` Rodrigo Rosatti Galvao
2018-04-02 14:21         ` Keith Busch
2018-04-02 14:50           ` Rodrigo Rosatti Galvao
2018-04-02 13:47 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93622938-f532-b8ac-2bca-fe40ed759e71@linux.vnet.ibm.com \
    --to=rosattig@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox