From: rosattig@linux.vnet.ibm.com (Rodrigo Rosatti Galvao)
Subject: [PATCH] nvmet: fix nvmet_execute_write_zeroes function
Date: Mon, 2 Apr 2018 11:50:45 -0300 [thread overview]
Message-ID: <c50d1e28-47f9-9ca3-23cf-bf425acd8a4b@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180402142141.GC28945@localhost.localdomain>
Thanks Keith. The patch you proposed worked fine!!
I just sent a V2 with that change!
On 04/02/2018 11:21 AM, Keith Busch wrote:
> On Mon, Apr 02, 2018@10:47:10AM -0300, Rodrigo Rosatti Galvao wrote:
>> One thing that I just forgot to explain previously, but I think its
>> relevant:
>>
>> 1. The command is failing with 4k logical block size, but works with 512B
>>
>> 2. With the patch, the command is working for both 512B and 4K.
> While you're not getting errors with your patch, you're not zeroing out
> the requested blocks, so that's a data corruption.
>
> The issue is the +1 is in the wrong place. It needs to be added to the
> native format prior to converting it to a 512b sector count. Do you want
> to resend with that change?
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
>
--
Rodrigo R. Galv?o
Intern - Linux Technology Center - IBM
next prev parent reply other threads:[~2018-04-02 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 21:18 [PATCH] nvmet: fix nvmet_execute_write_zeroes function Rodrigo R. Galvao
2018-03-30 21:24 ` Keith Busch
2018-03-30 21:48 ` Rodrigo Rosatti Galvão
2018-04-02 8:03 ` chaitany kulkarni
2018-04-02 13:47 ` Rodrigo Rosatti Galvao
2018-04-02 14:21 ` Keith Busch
2018-04-02 14:50 ` Rodrigo Rosatti Galvao [this message]
2018-04-02 13:47 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c50d1e28-47f9-9ca3-23cf-bf425acd8a4b@linux.vnet.ibm.com \
--to=rosattig@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox