From: Tokunori Ikegami <ikegami.t@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-sysfs: add 'fna' attribute
Date: Mon, 23 Sep 2024 03:50:52 +0900 [thread overview]
Message-ID: <9744ae62-9268-46f8-afef-fa775b00e249@gmail.com> (raw)
In-Reply-To: <ZvA5m6D0_tA-qKC9@kbusch-mbp>
There are many identify commands fields so if the nvme driver can be
kept the field values seems can be reduced to run many identify
commands. Thank you.
On 2024/09/23 0:36, Keith Busch wrote:
> At least for multi-namespace subsystems, I would agree knowing this
> value is important to understand the potentially undesired reprecussions
> of running a format command, but that logic ought to just go in tooling.
> And the meaning of the reported value here is not immediately obvious to
> a typical user without the spec in front of you, so I'm a little
> skeptical on exporting this attribute.
>
> nvme-cli already checks this on a format request, at least. You probably
> are not formatting very frequently anyway, so avoiding an identify
> command for such a low frequency event seems a bit overkill to me.
prev parent reply other threads:[~2024-09-22 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 15:45 [PATCH] nvme-sysfs: add 'fna' attribute Tokunori Ikegami
2024-09-22 15:36 ` Keith Busch
2024-09-22 18:50 ` Tokunori Ikegami [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9744ae62-9268-46f8-afef-fa775b00e249@gmail.com \
--to=ikegami.t@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox