From: Keith Busch <kbusch@kernel.org>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-sysfs: add 'fna' attribute
Date: Sun, 22 Sep 2024 17:36:59 +0200 [thread overview]
Message-ID: <ZvA5m6D0_tA-qKC9@kbusch-mbp> (raw)
In-Reply-To: <20240921154707.4362-1-ikegami.t@gmail.com>
On Sun, Sep 22, 2024 at 12:45:53AM +0900, Tokunori Ikegami wrote:
> The fna attriute is needed for the format NVM command.
At least for multi-namespace subsystems, I would agree knowing this
value is important to understand the potentially undesired reprecussions
of running a format command, but that logic ought to just go in tooling.
And the meaning of the reported value here is not immediately obvious to
a typical user without the spec in front of you, so I'm a little
skeptical on exporting this attribute.
nvme-cli already checks this on a format request, at least. You probably
are not formatting very frequently anyway, so avoiding an identify
command for such a low frequency event seems a bit overkill to me.
next prev parent reply other threads:[~2024-09-22 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 15:45 [PATCH] nvme-sysfs: add 'fna' attribute Tokunori Ikegami
2024-09-22 15:36 ` Keith Busch [this message]
2024-09-22 18:50 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvA5m6D0_tA-qKC9@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=ikegami.t@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox