From: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
To: "Keith Busch" <kbusch@kernel.org>,
"Maurizio Lombardi" <mlombard@redhat.com>
Cc: <hch@lst.de>, <sagi@grimberg.me>,
<linux-nvme@lists.infradead.org>, <bgurney@redhat.com>
Subject: Re: [RFC PATCH 0/1] enable quirks via module parameter
Date: Fri, 16 May 2025 18:52:31 +0200 [thread overview]
Message-ID: <D9XQOUZ07XJ6.S9M2PRLSX98K@bsdbackstore.eu> (raw)
In-Reply-To: <aCdmR_5pzny8nptW@kbusch-mbp>
On Fri May 16, 2025 at 6:22 PM CEST, Keith Busch wrote:
>> Can't we already do this for pci using the "new_id" attribute of the
>> nvme-pci driver? It takes up to 7 parameters, the last one being the
>> "driver_data", which is what we use to setup the quirks, and you can set
>> that value to anything you want through that interface.
>
> Oops, maybe not "anything you want", but you can set it to any value
> that exists in the driver's table. That may be an unnecessary limitation
> in the new_id_store() function, but let's see if that's sufficient
> before considering changing that.
Thanks for the suggestion, I really hadn't considered that.
So the idea would be to unbind the device and re-bind
it while specifying a different driver_data, correct?
If that's the case, I do have a concern: how can I do that
if the root filesystem is on the device that needs to be unbound?
Maurizio
prev parent reply other threads:[~2025-05-16 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 15:50 [RFC PATCH 0/1] enable quirks via module parameter Maurizio Lombardi
2025-05-16 15:50 ` [RFC PATCH 1/1] nvme: add support for dynamic quirk configuration " Maurizio Lombardi
2025-05-16 15:59 ` [RFC PATCH 0/1] enable quirks " Keith Busch
2025-05-16 16:22 ` Keith Busch
2025-05-16 16:52 ` Maurizio Lombardi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9XQOUZ07XJ6.S9M2PRLSX98K@bsdbackstore.eu \
--to=mlombard@bsdbackstore.eu \
--cc=bgurney@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox