From: Keith Busch <kbusch@kernel.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
bgurney@redhat.com, mlombard@bsdbackstore.eu
Subject: Re: [RFC PATCH 0/1] enable quirks via module parameter
Date: Fri, 16 May 2025 09:59:10 -0600 [thread overview]
Message-ID: <aCdgznvTZAJiPjM0@kbusch-mbp> (raw)
In-Reply-To: <20250516155025.44958-1-mlombard@redhat.com>
On Fri, May 16, 2025 at 05:50:24PM +0200, Maurizio Lombardi wrote:
> On some occasions, our customers have complained about misbehaving
> NVMe devices. We had to compile and provide them
> with a test kernel just to see if a quirk could resolve the issue.
>
> What do you think about allowing users to enable or disable a
> quirk via a module parameter, similar to how usbcore does it?
Can't we already do this for pci using the "new_id" attribute of the
nvme-pci driver? It takes up to 7 parameters, the last one being the
"driver_data", which is what we use to setup the quirks, and you can set
that value to anything you want through that interface.
next prev parent reply other threads:[~2025-05-16 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 15:50 [RFC PATCH 0/1] enable quirks via module parameter Maurizio Lombardi
2025-05-16 15:50 ` [RFC PATCH 1/1] nvme: add support for dynamic quirk configuration " Maurizio Lombardi
2025-05-16 15:59 ` Keith Busch [this message]
2025-05-16 16:22 ` [RFC PATCH 0/1] enable quirks " Keith Busch
2025-05-16 16:52 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCdgznvTZAJiPjM0@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=bgurney@redhat.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@bsdbackstore.eu \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox