From: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
To: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>,
"YunJe Shin" <yjshin0438@gmail.com>, <kbusch@kernel.org>
Cc: <linux-nvme@lists.infradead.org>, <hch@lst.de>,
<sagi@grimberg.me>, <gregkh@linuxfoundation.org>,
<security@kernel.org>, "YunJe Shin" <ioerts@kookmin.ac.kr>
Subject: Re: [PATCH v3] nvmet-tcp: reject H2CData before ICReq
Date: Tue, 27 Jan 2026 15:37:09 +0100 [thread overview]
Message-ID: <DFZG4OIFIHO8.313E3KOTXSDL5@bsdbackstore.eu> (raw)
In-Reply-To: <DFZFBKPGNCD4.3EKJ4G1H2GBDC@bsdbackstore.eu>
On Tue Jan 27, 2026 at 2:59 PM CET, Maurizio Lombardi wrote:
> On Mon Jan 26, 2026 at 7:41 AM CET, YunJe Shin wrote:
>> If H2CData arrives before ICReq/CONNECT, queue->connect is used but its
>> iov is not initialized yet, which can lead to a NULL dereference when
>> building the PDU iovec. Reject such requests early with -EPROTO.
>
> Doesn't nvmet_tcp_done_recv_pdu() reject all unexpected PDUs
> when the queue is in connecting state?
Nevermind, now I get what you mean: you can hit the bug if you send
H2CData after ICReq but before the execution
of the connect command.
Maurizio
next prev parent reply other threads:[~2026-01-27 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1a3d4d2d-db0c-4358-8229-c7d6f5e83bbe@grimberg.me>
2026-01-26 6:41 ` [PATCH v3] nvmet-tcp: reject H2CData before ICReq YunJe Shin
2026-01-27 13:59 ` Maurizio Lombardi
2026-01-27 14:37 ` Maurizio Lombardi [this message]
2026-01-27 15:17 ` Maurizio Lombardi
2026-01-28 0:45 ` yunje shin
2026-01-30 3:38 ` yunje shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFZG4OIFIHO8.313E3KOTXSDL5@bsdbackstore.eu \
--to=mlombard@bsdbackstore.eu \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=ioerts@kookmin.ac.kr \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=security@kernel.org \
--cc=yjshin0438@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).