From: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
To: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>,
"YunJe Shin" <yjshin0438@gmail.com>, <kbusch@kernel.org>
Cc: <linux-nvme@lists.infradead.org>, <hch@lst.de>,
<sagi@grimberg.me>, <gregkh@linuxfoundation.org>,
<security@kernel.org>, "YunJe Shin" <ioerts@kookmin.ac.kr>
Subject: Re: [PATCH v3] nvmet-tcp: reject H2CData before ICReq
Date: Tue, 27 Jan 2026 16:17:49 +0100 [thread overview]
Message-ID: <DFZGZT9C3D6B.346BT9Y4IGVFB@bsdbackstore.eu> (raw)
In-Reply-To: <DFZG4OIFIHO8.313E3KOTXSDL5@bsdbackstore.eu>
On Tue Jan 27, 2026 at 3:37 PM CET, Maurizio Lombardi wrote:
>
> Nevermind, now I get what you mean: you can hit the bug if you send
> H2CData after ICReq but before the execution
> of the connect command.
I was able to reproduce the crash:
[25362.399746] BUG: kernel NULL pointer dereference, address: 000000000000000c
[25362.403368] #PF: supervisor read access in kernel mode
[25362.405451] #PF: error_code(0x0000) - not-present page
[...]
[25362.430592] Call Trace:
[25362.430945] <TASK>
[25362.431250] ? show_trace_log_lvl+0x1b0/0x2f0
[25362.431910] ? show_trace_log_lvl+0x1b0/0x2f0
[25362.432507] ? nvmet_tcp_done_recv_pdu+0x299/0x2f0 [nvmet_tcp]
[25362.433285] ? __die_body.cold+0x8/0x12
[25362.433810] ? page_fault_oops+0x148/0x160
[25362.434388] ? exc_page_fault+0x73/0x160
[25362.434953] ? asm_exc_page_fault+0x26/0x30
[25362.435573] ? nvmet_tcp_build_pdu_iovec+0x4c/0xc0 [nvmet_tcp]
[25362.436357] nvmet_tcp_done_recv_pdu+0x299/0x2f0 [nvmet_tcp]
[25362.437113] nvmet_tcp_try_recv_pdu+0x1ef/0x2d0 [nvmet_tcp]
[25362.437856] ? sched_balance_update_blocked_averages+0xdd/0x1a0
[25362.438672] nvmet_tcp_io_work+0x70/0x8c0 [nvmet_tcp]
But it appears to have been already been fixed by commit 32b63acd78f577b332d976aa06b56e70d054cbba
(nvme-tcp: fix NULL pointer dereferences in nvmet_tcp_build_pdu_iovec)
dmesg output target-side:
[ 54.436869] nvmet_tcp: queue 0: H2CData PDU received for invalid command state (ttag 43981)
Maurizio
next prev parent reply other threads:[~2026-01-27 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1a3d4d2d-db0c-4358-8229-c7d6f5e83bbe@grimberg.me>
2026-01-26 6:41 ` [PATCH v3] nvmet-tcp: reject H2CData before ICReq YunJe Shin
2026-01-27 13:59 ` Maurizio Lombardi
2026-01-27 14:37 ` Maurizio Lombardi
2026-01-27 15:17 ` Maurizio Lombardi [this message]
2026-01-28 0:45 ` yunje shin
2026-01-30 3:38 ` yunje shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFZGZT9C3D6B.346BT9Y4IGVFB@bsdbackstore.eu \
--to=mlombard@bsdbackstore.eu \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=ioerts@kookmin.ac.kr \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=security@kernel.org \
--cc=yjshin0438@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox