* parse nvme connect Linux error codes properly
@ 2022-08-01 16:20 Engel, Amit
2022-08-01 18:35 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Engel, Amit @ 2022-08-01 16:20 UTC (permalink / raw)
To: linux-nvme@lists.infradead.org, Sagi Grimberg; +Cc: Engel, Amit
Hello,
we have encountered a wrong nvme/host/fabrics.c behavior as part of connect() failure.
Current nvmf_log_connect_error() code is assuming that 'int errval' is an unsigned nvme error, so it clears bit DNR=0x4000
The code should check if the error is negative (Linux error code) first.
If so, need to have a suitable log and return.
I can provide a simple fix for your review if you have no comments to the above analysis
Thanks,
Amit Engel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: parse nvme connect Linux error codes properly
2022-08-01 16:20 parse nvme connect Linux error codes properly Engel, Amit
@ 2022-08-01 18:35 ` Christoph Hellwig
2022-08-01 18:41 ` Engel, Amit
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2022-08-01 18:35 UTC (permalink / raw)
To: Engel, Amit; +Cc: linux-nvme@lists.infradead.org, Sagi Grimberg
On Mon, Aug 01, 2022 at 04:20:44PM +0000, Engel, Amit wrote:
> I can provide a simple fix for your review if you have no comments to the above analysis
Yes, please send the fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: parse nvme connect Linux error codes properly
2022-08-01 18:35 ` Christoph Hellwig
@ 2022-08-01 18:41 ` Engel, Amit
0 siblings, 0 replies; 3+ messages in thread
From: Engel, Amit @ 2022-08-01 18:41 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-nvme@lists.infradead.org, Sagi Grimberg
Just applied the patch
Thanks,
Amit
Internal Use - Confidential
-----Original Message-----
From: Christoph Hellwig <hch@infradead.org>
Sent: Monday, August 1, 2022 9:36 PM
To: Engel, Amit
Cc: linux-nvme@lists.infradead.org; Sagi Grimberg
Subject: Re: parse nvme connect Linux error codes properly
[EXTERNAL EMAIL]
On Mon, Aug 01, 2022 at 04:20:44PM +0000, Engel, Amit wrote:
> I can provide a simple fix for your review if you have no comments to the above analysis
Yes, please send the fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-01 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-01 16:20 parse nvme connect Linux error codes properly Engel, Amit
2022-08-01 18:35 ` Christoph Hellwig
2022-08-01 18:41 ` Engel, Amit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox