From: Keith Busch <kbusch@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: Robert Beckett <bob.beckett@collabora.com>,
Christoph Hellwig <hch@lst.de>, kbusch <kbusch@meta.com>,
linux-nvme <linux-nvme@lists.infradead.org>,
sagi <sagi@grimberg.me>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] nvme-pci: Remove O2 Queue Depth quirk
Date: Thu, 5 Dec 2024 14:03:00 -0800 [thread overview]
Message-ID: <Z1IjFDWwAonRI30D@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAPUE2utp0qOiMRNPwtn_gF45f2awa9UyNJ91zmpRbtu6zR5p9w@mail.gmail.com>
On Thu, Dec 05, 2024 at 01:53:29PM -0800, Gwendal Grignou wrote:
> Since limiting the queue depth to 2 is only needed for a small subset
> of eMMC memory modules that can be connected behind the bridge, would
> it make sense to apply this patch, but add the kernel module parameter
> mentioned earlier for impacted devices?
I don't think qd2 is needed for anyone, though. The problem sounds like
it was root caused to a boundary condition, which is addressed in a
different patch. But I am not 100% sure, as the thread was left hanging
for some external confirmation:
https://lore.kernel.org/linux-nvme/Z0DdU9K9QMFxBIL8@kbusch-mbp.dhcp.thefacebook.com/
prev parent reply other threads:[~2024-12-05 22:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 17:46 [PATCH] nvme-pci: qdepth 1 quirk Keith Busch
2024-09-12 6:57 ` Christoph Hellwig
2024-09-12 16:30 ` Robert Beckett
2024-10-29 2:42 ` [PATCH] nvme-pci: Remove O2 Queue Depth quirk Gwendal Grignou
2024-10-29 2:52 ` Greg KH
2024-10-29 7:41 ` Christoph Hellwig
2024-10-29 18:58 ` Gwendal Grignou
2024-10-29 19:16 ` Keith Busch
2024-11-07 16:50 ` [PATCH] nvme-pci: 512 byte dma pool segment quirk Bob Beckett
2024-11-07 17:19 ` Keith Busch
2024-11-07 17:35 ` Robert Beckett
2024-11-08 7:08 ` Christoph Hellwig
2024-10-29 19:18 ` [PATCH] nvme-pci: Remove O2 Queue Depth quirk Robert Beckett
2024-12-05 21:53 ` Gwendal Grignou
2024-12-05 22:03 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1IjFDWwAonRI30D@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=bob.beckett@collabora.com \
--cc=gwendal@chromium.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox