* [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk
@ 2024-12-16 22:28 Werner Sembach
2024-12-16 22:28 ` [PATCH v2 2/2] nvme-pci: Add TUXEDO IBP Gen9 " Werner Sembach
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Werner Sembach @ 2024-12-16 22:28 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Georg Gottleuber, Werner Sembach, linux-nvme, linux-kernel
From: Georg Gottleuber <ggo@tuxedocomputers.com>
On the TUXEDO InfinityFlex, a Samsung 990 Evo NVMe leads to a high power
consumption in s2idle sleep (4 watts).
This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with
a lower power consumption, typically around 1.4 watts.
Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
Cc: stable@vger.kernel.org
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1a5ba80f1811a..c5ecbda6bd1da 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3143,7 +3143,8 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
* because of high power consumption (> 2 Watt) in s2idle
* sleep. Only some boards with Intel CPU are affected.
*/
- if (dmi_match(DMI_BOARD_NAME, "GMxPXxx") ||
+ if (dmi_match(DMI_BOARD_NAME, "DN50Z-140HC-YD") ||
+ dmi_match(DMI_BOARD_NAME, "GMxPXxx") ||
dmi_match(DMI_BOARD_NAME, "PH4PG31") ||
dmi_match(DMI_BOARD_NAME, "PH4PRX1_PH6PRX1") ||
dmi_match(DMI_BOARD_NAME, "PH6PG01_PH6PG71"))
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] nvme-pci: Add TUXEDO IBP Gen9 to Samsung sleep quirk
2024-12-16 22:28 [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk Werner Sembach
@ 2024-12-16 22:28 ` Werner Sembach
2025-01-17 8:12 ` Christoph Hellwig
2025-01-14 16:40 ` [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex " Werner Sembach
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Werner Sembach @ 2024-12-16 22:28 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Georg Gottleuber, Werner Sembach, linux-nvme, linux-kernel
From: Georg Gottleuber <ggo@tuxedocomputers.com>
On the TUXEDO InfinityBook Pro Gen9 Intel, a Samsung 990 Evo NVMe leads to
a high power consumption in s2idle sleep (4 watts).
This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with
a lower power consumption, typically around 1.2 watts.
Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
Cc: stable@vger.kernel.org
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
drivers/nvme/host/pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c5ecbda6bd1da..f00f72d57355c 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3145,6 +3145,7 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
*/
if (dmi_match(DMI_BOARD_NAME, "DN50Z-140HC-YD") ||
dmi_match(DMI_BOARD_NAME, "GMxPXxx") ||
+ dmi_match(DMI_BOARD_NAME, "GXxMRXx") ||
dmi_match(DMI_BOARD_NAME, "PH4PG31") ||
dmi_match(DMI_BOARD_NAME, "PH4PRX1_PH6PRX1") ||
dmi_match(DMI_BOARD_NAME, "PH6PG01_PH6PG71"))
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk
2024-12-16 22:28 [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk Werner Sembach
2024-12-16 22:28 ` [PATCH v2 2/2] nvme-pci: Add TUXEDO IBP Gen9 " Werner Sembach
@ 2025-01-14 16:40 ` Werner Sembach
2025-01-17 8:11 ` Christoph Hellwig
2025-01-17 19:18 ` Keith Busch
3 siblings, 0 replies; 6+ messages in thread
From: Werner Sembach @ 2025-01-14 16:40 UTC (permalink / raw)
To: Jens Axboe, Keith Busch, Christoph Hellwig, Sagi Grimberg
Cc: ggo, linux-kernel, linux-nvme
Hi,
gentle reminder for these two patches to make sure they weren't forgotten over
the holidays.
Best regards,
Werner Sembach
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk
2024-12-16 22:28 [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk Werner Sembach
2024-12-16 22:28 ` [PATCH v2 2/2] nvme-pci: Add TUXEDO IBP Gen9 " Werner Sembach
2025-01-14 16:40 ` [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex " Werner Sembach
@ 2025-01-17 8:11 ` Christoph Hellwig
2025-01-17 19:18 ` Keith Busch
3 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2025-01-17 8:11 UTC (permalink / raw)
To: Werner Sembach
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Georg Gottleuber, linux-nvme, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] nvme-pci: Add TUXEDO IBP Gen9 to Samsung sleep quirk
2024-12-16 22:28 ` [PATCH v2 2/2] nvme-pci: Add TUXEDO IBP Gen9 " Werner Sembach
@ 2025-01-17 8:12 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2025-01-17 8:12 UTC (permalink / raw)
To: Werner Sembach
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Georg Gottleuber, linux-nvme, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk
2024-12-16 22:28 [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk Werner Sembach
` (2 preceding siblings ...)
2025-01-17 8:11 ` Christoph Hellwig
@ 2025-01-17 19:18 ` Keith Busch
3 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2025-01-17 19:18 UTC (permalink / raw)
To: Werner Sembach
Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, Georg Gottleuber,
linux-nvme, linux-kernel
On Mon, Dec 16, 2024 at 11:28:03PM +0100, Werner Sembach wrote:
> From: Georg Gottleuber <ggo@tuxedocomputers.com>
>
> On the TUXEDO InfinityFlex, a Samsung 990 Evo NVMe leads to a high power
> consumption in s2idle sleep (4 watts).
>
> This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with
> a lower power consumption, typically around 1.4 watts.
Thanks, both patches applied to nvme-6.14.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-01-17 19:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-16 22:28 [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex to Samsung sleep quirk Werner Sembach
2024-12-16 22:28 ` [PATCH v2 2/2] nvme-pci: Add TUXEDO IBP Gen9 " Werner Sembach
2025-01-17 8:12 ` Christoph Hellwig
2025-01-14 16:40 ` [PATCH v2 1/2] nvme-pci: Add TUXEDO InfinityFlex " Werner Sembach
2025-01-17 8:11 ` Christoph Hellwig
2025-01-17 19:18 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox