From: Keith Busch <kbusch@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Maurizio Lombardi <mlombard@redhat.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] nvme-tcp: fix connect failure on receiving partial ICResp PDU
Date: Tue, 18 Feb 2025 08:45:37 -0700 [thread overview]
Message-ID: <Z7SrIT9m51w8A4DC@kbusch-mbp> (raw)
In-Reply-To: <20250124184311.1642797-1-csander@purestorage.com>
On Fri, Jan 24, 2025 at 11:43:10AM -0700, Caleb Sander Mateos wrote:
> nvme_tcp_init_connection() attempts to receive an ICResp PDU but only
> checks that the return value from recvmsg() is non-negative. If the
> sender closes the TCP connection or sends fewer than 128 bytes, this
> check will pass even though the full PDU wasn't received.
>
> Ensure the full ICResp PDU is received by checking that recvmsg()
> returns the expected 128 bytes.
Thanks, applied to nvme-6.14.
prev parent reply other threads:[~2025-02-18 15:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 18:43 [PATCH v4] nvme-tcp: fix connect failure on receiving partial ICResp PDU Caleb Sander Mateos
2025-01-26 8:01 ` Sagi Grimberg
2025-01-27 7:37 ` Hannes Reinecke
2025-01-27 8:09 ` Hannes Reinecke
2025-01-27 18:06 ` Caleb Sander
2025-01-27 17:38 ` Caleb Sander
2025-01-27 17:51 ` Maurizio Lombardi
2025-01-28 8:28 ` Hannes Reinecke
2025-01-28 22:02 ` Caleb Sander
2025-01-31 8:17 ` Sagi Grimberg
2025-02-03 0:19 ` Caleb Sander
2025-02-03 7:20 ` Hannes Reinecke
2025-02-04 22:20 ` Caleb Sander
2025-02-10 17:24 ` Caleb Sander
2025-02-11 22:20 ` Hannes Reinecke
2025-02-17 7:11 ` Sagi Grimberg
2025-02-18 15:45 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7SrIT9m51w8A4DC@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox