From: Keith Busch <kbusch@kernel.org>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: "Keith Busch" <kbusch@meta.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"Cláudio Sampaio" <patola@gmail.com>,
"Felix Yan" <felixonmars@archlinux.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] nvme: avoid bogus CRTO values
Date: Wed, 13 Sep 2023 08:20:09 -0700 [thread overview]
Message-ID: <ZQHTKQLKFE9Iupp0@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <ZQGqNZD9QweQQRmF@x1-carbon>
On Wed, Sep 13, 2023 at 12:25:29PM +0000, Niklas Cassel wrote:
> > + if (ctrl->ctrl_config & NVME_CC_CRIME)
> > + timeout = max(timeout, NVME_CRTO_CRIMT(crto));
> > + else
> > + timeout = max(timeout, NVME_CRTO_CRWMT(crto));
>
> I saw the original bug report.
> But wasn't the problem that these were compared before NVME_CC_CRIME had
> been written?
>
> i.e. is this max() check still needed for the bug reporter's NVMe drive,
> after NVME_CC_CRIME was been written and CAP has been re-read?
> (If so, would a quirk be better?)
The values reported in CRTO don't change with the CC writes. It's only
CAP.TO that can change, so we still can't rely on CRTO at any point in
the sequence for these devices.
next prev parent reply other threads:[~2023-09-13 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 21:47 [PATCH] nvme: avoid bogus CRTO values Keith Busch
2023-09-13 10:50 ` Christoph Hellwig
2023-09-13 15:15 ` Keith Busch
2023-09-13 10:53 ` Sagi Grimberg
2023-09-13 12:25 ` Niklas Cassel
2023-09-13 15:20 ` Keith Busch [this message]
2023-09-13 16:14 ` Niklas Cassel
2023-09-13 16:46 ` Keith Busch
2023-09-15 21:31 ` Niklas Cassel
2023-09-15 21:50 ` Keith Busch
2023-09-15 22:14 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQHTKQLKFE9Iupp0@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=Niklas.Cassel@wdc.com \
--cc=felixonmars@archlinux.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=patola@gmail.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox