From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "Keith Busch" <kbusch@meta.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"Cláudio Sampaio" <patola@gmail.com>,
"Felix Yan" <felixonmars@archlinux.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] nvme: avoid bogus CRTO values
Date: Fri, 15 Sep 2023 22:14:52 +0000 [thread overview]
Message-ID: <ZQTXVDmb+DYZX9Ex@x1-carbon> (raw)
In-Reply-To: <ZQTRnJm0z3ZE3x4I@kbusch-mbp>
On Fri, Sep 15, 2023 at 02:50:20PM -0700, Keith Busch wrote:
> On Fri, Sep 15, 2023 at 09:31:44PM +0000, Niklas Cassel wrote:
> > I'm not saying that these controllers shouldn't work with Linux.
> > However, these controller used to work with CC.CRIME == 0, so perhaps
> > we should continue to use them that way?
>
> Perhaps I missed something, but I didn't get any indication that these
> controllers were reporting CRIMS capability. They're just reporting
> CRWMS as far as I know, so CRIME doesn't apply. I only included that
> case in the patch for completeness.
Yes, you are right of course.
My brain started thinking about this issue when relaxing...
but I guess that my brain got some details wrong when context
switching to this problem again after too much idle...
Have a nice weekend!
Kind regards,
Niklas
prev parent reply other threads:[~2023-09-15 22:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 21:47 [PATCH] nvme: avoid bogus CRTO values Keith Busch
2023-09-13 10:50 ` Christoph Hellwig
2023-09-13 15:15 ` Keith Busch
2023-09-13 10:53 ` Sagi Grimberg
2023-09-13 12:25 ` Niklas Cassel
2023-09-13 15:20 ` Keith Busch
2023-09-13 16:14 ` Niklas Cassel
2023-09-13 16:46 ` Keith Busch
2023-09-15 21:31 ` Niklas Cassel
2023-09-15 21:50 ` Keith Busch
2023-09-15 22:14 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQTXVDmb+DYZX9Ex@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=felixonmars@archlinux.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=patola@gmail.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox