* [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions
@ 2023-11-29 4:49 Shin'ichiro Kawasaki
2023-11-30 22:28 ` Keith Busch
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Shin'ichiro Kawasaki @ 2023-11-29 4:49 UTC (permalink / raw)
To: linux-nvme, Hannes Reinecke; +Cc: Keith Busch, Shin'ichiro Kawasaki
Currently two similar config options NVME_HOST_AUTH and NVME_TARGET_AUTH
have almost same descriptions. It is confusing to choose them in
menuconfig. Improve the descriptions to distinguish them.
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
drivers/nvme/host/Kconfig | 5 +++--
drivers/nvme/target/Kconfig | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 8fe2dd619e80..b309c8be720f 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -107,11 +107,12 @@ config NVME_TCP_TLS
If unsure, say N.
config NVME_HOST_AUTH
- bool "NVM Express over Fabrics In-Band Authentication"
+ bool "NVMe over Fabrics In-Band Authentication in host side"
depends on NVME_CORE
select NVME_AUTH
help
- This provides support for NVMe over Fabrics In-Band Authentication.
+ This provides support for NVMe over Fabrics In-Band Authentication in
+ host side.
If unsure, say N.
diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
index e1ebc73f3e5e..872dd1a0acd8 100644
--- a/drivers/nvme/target/Kconfig
+++ b/drivers/nvme/target/Kconfig
@@ -99,10 +99,11 @@ config NVME_TARGET_TCP_TLS
If unsure, say N.
config NVME_TARGET_AUTH
- bool "NVMe over Fabrics In-band Authentication support"
+ bool "NVMe over Fabrics In-band Authentication in target side"
depends on NVME_TARGET
select NVME_AUTH
help
- This enables support for NVMe over Fabrics In-band Authentication
+ This enables support for NVMe over Fabrics In-band Authentication in
+ target side.
If unsure, say N.
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions
2023-11-29 4:49 [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions Shin'ichiro Kawasaki
@ 2023-11-30 22:28 ` Keith Busch
2023-12-04 8:08 ` Christoph Hellwig
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2023-11-30 22:28 UTC (permalink / raw)
To: Shin'ichiro Kawasaki; +Cc: linux-nvme, Hannes Reinecke
On Wed, Nov 29, 2023 at 01:49:51PM +0900, Shin'ichiro Kawasaki wrote:
> Currently two similar config options NVME_HOST_AUTH and NVME_TARGET_AUTH
> have almost same descriptions. It is confusing to choose them in
> menuconfig. Improve the descriptions to distinguish them.
Looks good to me.
Reviewed-by: Keith Busch <kbusch@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions
2023-11-29 4:49 [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions Shin'ichiro Kawasaki
2023-11-30 22:28 ` Keith Busch
@ 2023-12-04 8:08 ` Christoph Hellwig
2023-12-04 8:22 ` Sagi Grimberg
2023-12-04 16:40 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2023-12-04 8:08 UTC (permalink / raw)
To: Shin'ichiro Kawasaki; +Cc: linux-nvme, Hannes Reinecke, Keith Busch
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions
2023-11-29 4:49 [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions Shin'ichiro Kawasaki
2023-11-30 22:28 ` Keith Busch
2023-12-04 8:08 ` Christoph Hellwig
@ 2023-12-04 8:22 ` Sagi Grimberg
2023-12-04 16:40 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2023-12-04 8:22 UTC (permalink / raw)
To: Shin'ichiro Kawasaki, linux-nvme, Hannes Reinecke; +Cc: Keith Busch
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions
2023-11-29 4:49 [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions Shin'ichiro Kawasaki
` (2 preceding siblings ...)
2023-12-04 8:22 ` Sagi Grimberg
@ 2023-12-04 16:40 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2023-12-04 16:40 UTC (permalink / raw)
To: Shin'ichiro Kawasaki; +Cc: linux-nvme, Hannes Reinecke
Thanks, applied to nvme-6.7.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-04 16:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-29 4:49 [PATCH] nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions Shin'ichiro Kawasaki
2023-11-30 22:28 ` Keith Busch
2023-12-04 8:08 ` Christoph Hellwig
2023-12-04 8:22 ` Sagi Grimberg
2023-12-04 16:40 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox