* [PATCH v2] nvme-fabrics: check max outstanding commands
@ 2024-02-28 2:37 Guixin Liu
2024-02-28 5:34 ` Chaitanya Kulkarni
2024-02-28 16:03 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Guixin Liu @ 2024-02-28 2:37 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi; +Cc: linux-nvme
Maxcmd is mandatory for fabrics, check it early to identify the root
cause instead of waiting for it to propagate to "sqsize" and "allocing
queue".
By the way, change nvme_check_ctrl_fabric_info() to
nvmf_validate_identify_ctrl().
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
Changes from v1 to v2:
- Revert nvme_check_ctrl_fabric_info() function name change.
drivers/nvme/host/core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 0a96362912ce..7c247b849bbb 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3117,6 +3117,11 @@ static int nvme_check_ctrl_fabric_info(struct nvme_ctrl *ctrl, struct nvme_id_ct
return -EINVAL;
}
+ if (!ctrl->maxcmd) {
+ dev_err(ctrl->device, "Maximum outstanding commands is 0\n");
+ return -EINVAL;
+ }
+
return 0;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] nvme-fabrics: check max outstanding commands
2024-02-28 2:37 [PATCH v2] nvme-fabrics: check max outstanding commands Guixin Liu
@ 2024-02-28 5:34 ` Chaitanya Kulkarni
2024-02-28 16:03 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2024-02-28 5:34 UTC (permalink / raw)
To: Guixin Liu, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org
On 2/27/24 18:37, Guixin Liu wrote:
> Maxcmd is mandatory for fabrics, check it early to identify the root
> cause instead of waiting for it to propagate to "sqsize" and "allocing
> queue".
>
> By the way, change nvme_check_ctrl_fabric_info() to
> nvmf_validate_identify_ctrl().
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> Changes from v1 to v2:
> - Revert nvme_check_ctrl_fabric_info() function name change.
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] nvme-fabrics: check max outstanding commands
2024-02-28 2:37 [PATCH v2] nvme-fabrics: check max outstanding commands Guixin Liu
2024-02-28 5:34 ` Chaitanya Kulkarni
@ 2024-02-28 16:03 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2024-02-28 16:03 UTC (permalink / raw)
To: Guixin Liu; +Cc: axboe, hch, sagi, linux-nvme
Thanks, applied to nvme-6.9.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-28 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-28 2:37 [PATCH v2] nvme-fabrics: check max outstanding commands Guixin Liu
2024-02-28 5:34 ` Chaitanya Kulkarni
2024-02-28 16:03 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox