[PATCH] nvme: Remove unused parameter

[PATCH] nvme: Remove unused parameter

[Nilay Shroff]

The "name" field in struct nvme_ctrl is unsued so removing it.
This would help save 12 bytes of space for each nvme_ctrl instance
created.

Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
 drivers/nvme/host/nvme.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index ae5314d32943..da57947130cc 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -301,7 +301,6 @@ struct nvme_ctrl {
 
 	struct opal_dev *opal_dev;
 
-	char name[12];
 	u16 cntlid;
 
 	u16 mtfa;
-- 
2.45.2

Re: [PATCH] nvme: Remove unused parameter

[Kanchan Joshi]

Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>

Re: [PATCH] nvme: Remove unused parameter

[Christoph Hellwig]

On Wed, Aug 14, 2024 at 07:26:50PM +0530, Nilay Shroff wrote:
> The "name" field in struct nvme_ctrl is unsued so removing it.
> This would help save 12 bytes of space for each nvme_ctrl instance
> created.

name is a structure member, not a parameter.

The code change itself look fine, though.

Re: [PATCH] nvme: Remove unused parameter

[Nilay Shroff]

Hi Christoph,

On 8/16/24 11:11, Christoph Hellwig wrote:
> On Wed, Aug 14, 2024 at 07:26:50PM +0530, Nilay Shroff wrote:
>> The "name" field in struct nvme_ctrl is unsued so removing it.
>> This would help save 12 bytes of space for each nvme_ctrl instance
>> created.
> 
> name is a structure member, not a parameter.
> 
> The code change itself look fine, though.
> 
> 
Yeah ok, if you prefer, shall I update the patch subject line and 
resend the patch?

Thanks,
--Nilay

Re: [PATCH] nvme: Remove unused parameter

[Christoph Hellwig]

On Fri, Aug 16, 2024 at 12:30:45PM +0530, Nilay Shroff wrote:
> Yeah ok, if you prefer, shall I update the patch subject line and 
> resend the patch?

Maybe Keith can just fix it up.

Re: [PATCH] nvme: Remove unused parameter

[Nilay Shroff]

On 8/16/24 13:29, Christoph Hellwig wrote:
> On Fri, Aug 16, 2024 at 12:30:45PM +0530, Nilay Shroff wrote:
>> Yeah ok, if you prefer, shall I update the patch subject line and 
>> resend the patch?
> 
> Maybe Keith can just fix it up.
> 
OK thanks!

--Nilay

Re: [PATCH] nvme: Remove unused parameter

[Keith Busch]

Thanks, applied to nvme-6.11 with subject change "parameter" to "field".

[PATCH] nvme: remove unused parameter

[Kanchan Joshi]

First parameter of nvme_init_integrity() is unused.
Remove it, and modify the callers.

Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
---
 drivers/nvme/host/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index e78ef31eeef0..d7f5b24ce003 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1756,7 +1756,7 @@ int nvme_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 	return 0;
 }
 
-static bool nvme_init_integrity(struct gendisk *disk, struct nvme_ns_head *head,
+static bool nvme_init_integrity(struct nvme_ns_head *head,
 		struct queue_limits *lim)
 {
 	struct blk_integrity *bi = &lim->integrity;
@@ -2175,7 +2175,7 @@ static int nvme_update_ns_info_block(struct nvme_ns *ns,
 	 * I/O to namespaces with metadata except when the namespace supports
 	 * PI, as it can strip/insert in that case.
 	 */
-	if (!nvme_init_integrity(ns->disk, ns->head, &lim))
+	if (!nvme_init_integrity(ns->head, &lim))
 		capacity = 0;
 
 	ret = queue_limits_commit_update(ns->disk->queue, &lim);
@@ -2279,7 +2279,7 @@ static int nvme_update_ns_info(struct nvme_ns *ns, struct nvme_ns_info *info)
 		if (unsupported)
 			ns->head->disk->flags |= GENHD_FL_HIDDEN;
 		else
-			nvme_init_integrity(ns->head->disk, ns->head, &lim);
+			nvme_init_integrity(ns->head, &lim);
 		ret = queue_limits_commit_update(ns->head->disk->queue, &lim);
 
 		set_capacity_and_notify(ns->head->disk, get_capacity(ns->disk));
-- 
2.25.1

Re: [PATCH] nvme: remove unused parameter

[Sagi Grimberg]

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

Re: [PATCH] nvme: remove unused parameter

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] nvme: remove unused parameter

[Keith Busch]

Thanks, applied to nvme-6.11.

[PATCH] nvme: remove unused parameter

[Keith Busch]

nvme_alloc_ns_head() doesn't use the 'struct nvme_id_ns' parameter.
Remove it, and update caller accordingly.

Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/nvme/host/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index d219a531ba4f..05aa3525ef06 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3410,8 +3410,7 @@ static int __nvme_check_ids(struct nvme_subsystem *subsys,
 }
 
 static struct nvme_ns_head *nvme_alloc_ns_head(struct nvme_ctrl *ctrl,
-		unsigned nsid, struct nvme_id_ns *id,
-		struct nvme_ns_ids *ids)
+		unsigned nsid, struct nvme_ns_ids *ids)
 {
 	struct nvme_ns_head *head;
 	size_t size = sizeof(*head);
@@ -3482,7 +3481,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, unsigned nsid,
 	if (is_shared)
 		head = nvme_find_ns_head(ctrl->subsys, nsid);
 	if (!head) {
-		head = nvme_alloc_ns_head(ctrl, nsid, id, &ids);
+		head = nvme_alloc_ns_head(ctrl, nsid, &ids);
 		if (IS_ERR(head)) {
 			ret = PTR_ERR(head);
 			goto out_unlock;
-- 
2.24.1


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvme: remove unused parameter

[Christoph Hellwig]

On Fri, Apr 03, 2020 at 09:24:09AM -0700, Keith Busch wrote:
> nvme_alloc_ns_head() doesn't use the 'struct nvme_id_ns' parameter.
> Remove it, and update caller accordingly.

applied to nvme-5.8.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme