Re: [PATCH v17 2/2] nvmet: support reservation feature

[Keith Busch <kbusch@kernel.org>]

On Tue, Oct 22, 2024 at 09:43:01AM +0800, Guixin Liu wrote:
> 
> 在 2024/10/22 06:33, Keith Busch 写道:
> > On Mon, Oct 21, 2024 at 07:03:31PM +0800, Guixin Liu wrote:
> > > new file mode 100644
> > > index 000000000000..aa69656a0ac5
> > > --- /dev/null
> > > +++ b/drivers/nvme/target/pr.c
> > > @@ -0,0 +1,1186 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * NVMe over Fabrics Persist Reservation.
> > > + * Copyright (c) 2024 Guixin Liu, Alibaba Group.
> > > + * All rights reserved.
> > > + */
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > > +#include <linux/unaligned.h>
> > I don't find any such file. Should this must have said <asm/unaligned.h>
> > instead? Curious to know if the target side was actually tested.
> 
> New 6.12-rc2 add a commit 5f60d5f6bbc12e782fac78110b0ee62698f3b576("move
> asm/unaligned.h to linux/unaligned.h"), I change my code to fit this.
> 
> You can find the discission in v14.

I see, thank you for the clarification. I hadn't been paying close
enough attention at that discussion.

So, minor problem here. This new feature is 6.13 material, but our
upstream block branch has forked before that commit. IMO, I feel
introducing that header movement after the merge window is poorly
timed...

Anyway, I don't think I can get away with something this large in 6.12,
so it's going to have to be in our second 6.13 nvme pull request after
the next rebase. I've set myself a reminder to merge this when that
happens.

Thanks!