From: Guixin Liu <kanie@linux.alibaba.com>
To: Keith Busch <kbusch@kernel.org>
Cc: hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
shinichiro.kawasaki@wdc.com, d.bogdanov@yadro.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v17 2/2] nvmet: support reservation feature
Date: Tue, 22 Oct 2024 09:43:01 +0800 [thread overview]
Message-ID: <b4bde72c-7123-4594-a064-a39aef7fa7ec@linux.alibaba.com> (raw)
In-Reply-To: <ZxbWxuzH3u6hAezr@kbusch-mbp>
在 2024/10/22 06:33, Keith Busch 写道:
> On Mon, Oct 21, 2024 at 07:03:31PM +0800, Guixin Liu wrote:
>> new file mode 100644
>> index 000000000000..aa69656a0ac5
>> --- /dev/null
>> +++ b/drivers/nvme/target/pr.c
>> @@ -0,0 +1,1186 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * NVMe over Fabrics Persist Reservation.
>> + * Copyright (c) 2024 Guixin Liu, Alibaba Group.
>> + * All rights reserved.
>> + */
>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> +#include <linux/unaligned.h>
> I don't find any such file. Should this must have said <asm/unaligned.h>
> instead? Curious to know if the target side was actually tested.
New 6.12-rc2 add a commit 5f60d5f6bbc12e782fac78110b0ee62698f3b576("move
asm/unaligned.h to linux/unaligned.h"), I change my code to fit this.
You can find the discission in v14.
Best Regards,
Guixin Liu
next prev parent reply other threads:[~2024-10-22 1:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 11:03 [PATCH v17 0/2] Implement the NVMe reservation feature Guixin Liu
2024-10-21 11:03 ` [PATCH v17 1/2] nvme: add reservation command's defines Guixin Liu
2024-10-21 11:03 ` [PATCH v17 2/2] nvmet: support reservation feature Guixin Liu
2024-10-21 22:33 ` Keith Busch
2024-10-22 1:43 ` Guixin Liu [this message]
2024-10-22 2:07 ` Keith Busch
2024-10-22 6:06 ` Christoph Hellwig
2024-10-22 14:13 ` Jens Axboe
2024-10-22 14:18 ` Jens Axboe
2024-10-22 14:19 ` Christoph Hellwig
2024-10-22 14:34 ` Keith Busch
2024-10-22 13:18 ` Sagi Grimberg
2024-10-22 14:20 ` Christoph Hellwig
2024-10-23 7:35 ` Guixin Liu
2024-10-23 12:24 ` Christoph Hellwig
2024-10-24 1:32 ` Guixin Liu
2024-10-23 7:06 ` Guixin Liu
2024-10-23 13:30 ` Dmitry Bogdanov
2024-10-24 2:04 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4bde72c-7123-4594-a064-a39aef7fa7ec@linux.alibaba.com \
--to=kanie@linux.alibaba.com \
--cc=d.bogdanov@yadro.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox