From: Keith Busch <kbusch@kernel.org>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3] nvme: fix nvme_ns_has_pi() to check PI size if metadata size or below
Date: Tue, 22 Oct 2024 13:20:44 -0600 [thread overview]
Message-ID: <Zxf7DJ-BTW9odH7M@kbusch-mbp> (raw)
In-Reply-To: <20241022181132.19871-1-ikegami.t@gmail.com>
On Wed, Oct 23, 2024 at 03:10:54AM +0900, Tokunori Ikegami wrote:
> The PI is the first bytes or last bytes of the metadata.
> So its size is not equal to the metadata size only but below also.
This is still wrong because the only users of this function are with
respect to PRACT. If anything, you could change the name from "has_pi"
to "supports_pract", or something like that.
> static inline bool nvme_ns_has_pi(struct nvme_ns_head *head)
> {
> - return head->pi_type && head->ms == head->pi_size;
> + return head->pi_type && head->ms >= head->pi_size;
> }
next prev parent reply other threads:[~2024-10-22 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 18:10 [PATCH v3] nvme: fix nvme_ns_has_pi() to check PI size if metadata size or below Tokunori Ikegami
2024-10-22 19:20 ` Keith Busch [this message]
2024-10-23 10:10 ` Tokunori Ikegami
2024-10-23 12:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxf7DJ-BTW9odH7M@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=ikegami.t@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox