From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@kernel.org>
Cc: Tokunori Ikegami <ikegami.t@gmail.com>,
linux-nvme@lists.infradead.org,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Israel Rukshin <israelr@nvidia.com>
Subject: Re: [PATCH v3] nvme: fix nvme_ns_has_pi() to check PI size if metadata size or below
Date: Wed, 23 Oct 2024 05:45:13 -0700 [thread overview]
Message-ID: <Zxjv2TL6-3557BvJ@infradead.org> (raw)
In-Reply-To: <Zxf7DJ-BTW9odH7M@kbusch-mbp>
On Tue, Oct 22, 2024 at 01:20:44PM -0600, Keith Busch wrote:
> On Wed, Oct 23, 2024 at 03:10:54AM +0900, Tokunori Ikegami wrote:
> > The PI is the first bytes or last bytes of the metadata.
> > So its size is not equal to the metadata size only but below also.
>
> This is still wrong because the only users of this function are with
> respect to PRACT. If anything, you could change the name from "has_pi"
> to "supports_pract", or something like that.
It's also use in the NVME_NS_METADATA_SUPPORTED for fabrics.
Where fabrics really means RDMA with the Mellanox PI offload. I don't
really know if that supports PI smaller than the metadata size offhand.
prev parent reply other threads:[~2024-10-23 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 18:10 [PATCH v3] nvme: fix nvme_ns_has_pi() to check PI size if metadata size or below Tokunori Ikegami
2024-10-22 19:20 ` Keith Busch
2024-10-23 10:10 ` Tokunori Ikegami
2024-10-23 12:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxjv2TL6-3557BvJ@infradead.org \
--to=hch@infradead.org \
--cc=ikegami.t@gmail.com \
--cc=israelr@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox