From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: mengfanhui <mengfanhui@kylinos.cn>
Cc: Sagi Grimberg <sagi@grimberg.me>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH] nvme/auth: optimize code redundancy and provide code quality
Date: Mon, 15 Jan 2024 22:21:30 +0000 [thread overview]
Message-ID: <a60bf7f7-e520-400a-ae68-73f448f0e3f9@nvidia.com> (raw)
In-Reply-To: <4ad9d0a8-00b6-4970-9127-ccbe1d2f26bf@grimberg.me>
>> + return transformed_key ? transformed_key : ERR_PTR(-ENOMEM);
I've received many comments about not using ?: in kernel code as
if .. else is preferred way, not sure if this is a good idea
-ck
prev parent reply other threads:[~2024-01-15 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 6:52 [PATCH] nvme/auth: optimize code redundancy and provide code quality mengfanhui
2024-01-15 12:51 ` Sagi Grimberg
2024-01-15 22:21 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a60bf7f7-e520-400a-ae68-73f448f0e3f9@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mengfanhui@kylinos.cn \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox