From: Keith Busch <kbusch@kernel.org>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Caleb Sander Mateos <csander@purestorage.com>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme/pci: make PRP list DMA pools per-NUMA-node
Date: Mon, 21 Apr 2025 08:27:31 -0600 [thread overview]
Message-ID: <aAZV04hiWIz2UT2E@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <be873f40-d3c4-4f0e-8b36-dc6e4f5bcf48@samsung.com>
On Mon, Apr 21, 2025 at 12:43:24PM +0530, Kanchan Joshi wrote:
> On 4/20/2025 10:14 PM, Caleb Sander Mateos wrote:
> > struct nvme_dev {
> > struct nvme_queue *queues;
> > struct blk_mq_tag_set tagset;
> > struct blk_mq_tag_set admin_tagset;
> > u32 __iomem *dbs;
> > struct device *dev;
> > - struct dma_pool *prp_page_pool;
> > - struct dma_pool *prp_small_pool;
> > + struct nvme_prp_dma_pools prp_pools[MAX_NUMNODES];
>
> I wonder if it is worth to make this dynamic using nr_node_ids?
Yeah, I think so. MAX_NUMNODES is derived from a config value that may
be much larger than what the platform actually has.
prev parent reply other threads:[~2025-04-21 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250420164653epcas5p10dba2c638655fd4b16c6553d5125a3a0@epcas5p1.samsung.com>
2025-04-20 16:44 ` [PATCH] nvme/pci: make PRP list DMA pools per-NUMA-node Caleb Sander Mateos
2025-04-21 7:09 ` Kanchan Joshi
2025-04-21 14:50 ` Caleb Sander Mateos
2025-04-21 7:13 ` Kanchan Joshi
2025-04-21 14:27 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAZV04hiWIz2UT2E@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox