From: Kanchan Joshi <joshi.k@samsung.com>
To: Caleb Sander Mateos <csander@purestorage.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme/pci: make PRP list DMA pools per-NUMA-node
Date: Mon, 21 Apr 2025 12:39:34 +0530 [thread overview]
Message-ID: <ba40abc8-8b41-4e2c-a700-04e8e424bcc3@samsung.com> (raw)
In-Reply-To: <20250420164450.1144416-1-csander@purestorage.com>
On 4/20/2025 10:14 PM, Caleb Sander Mateos wrote:
> static int nvme_init_hctx(struct blk_mq_hw_ctx *hctx, void *data,
> unsigned int hctx_idx)
Missing this handling for admin queue.
We may go to that case (i.e., admin command with data payload > 1
segment) less often. But when we do, this code will give
null-pointer-deference.
next prev parent reply other threads:[~2025-04-21 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250420164653epcas5p10dba2c638655fd4b16c6553d5125a3a0@epcas5p1.samsung.com>
2025-04-20 16:44 ` [PATCH] nvme/pci: make PRP list DMA pools per-NUMA-node Caleb Sander Mateos
2025-04-21 7:09 ` Kanchan Joshi [this message]
2025-04-21 14:50 ` Caleb Sander Mateos
2025-04-21 7:13 ` Kanchan Joshi
2025-04-21 14:27 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba40abc8-8b41-4e2c-a700-04e8e424bcc3@samsung.com \
--to=joshi.k@samsung.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox