From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: uring_cmd specific request_queue for SGLs
Date: Mon, 30 Jun 2025 08:04:47 -0600 [thread overview]
Message-ID: <aGKZf5gX7_JPe4-g@kbusch-mbp> (raw)
In-Reply-To: <20250630060016.GA28775@lst.de>
On Mon, Jun 30, 2025 at 08:00:16AM +0200, Christoph Hellwig wrote:
> On Fri, Jun 27, 2025 at 09:34:56AM -0600, Keith Busch wrote:
> > Back to this patch, I get that this uring_cmd path wouldn't be able to
> > use the more efficient coalesced mapping when the IOMMU is on, and
> > instead map each segment indiviually. I think that's still better than
> > the alternative, though.
>
> My back on the envelope calculations (for 8 byte metadata chunks)
> suggests otherwise, but I never got around fully benchmarking it.
> If you do have a representation workload that you care about I'd love to
> see the numbers.
Metadata isn't actually the important part of this patch.
The workload just receives data from a iouring zero-copy network and
writes them out to disk using uring_cmd. The incoming data can have
various offsets, so it often sends an iovec with page gaps.
Currently the kernel provides a bounce buffer when there are page gaps.
That's obviously undesirable when the hardware is capable of handling
the original vector directly.
The options to avoid the copies are either:
a. Force the application to split each iovec into a separate command
b. Relax the kernel's limits to match the hardware's capabilities
This patch is trying to do "b".
next prev parent reply other threads:[~2025-06-30 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 21:14 [PATCH] nvme: uring_cmd specific request_queue for SGLs Keith Busch
2025-06-25 6:09 ` Christoph Hellwig
2025-06-25 22:08 ` Keith Busch
2025-06-26 5:14 ` Christoph Hellwig
2025-06-26 15:29 ` Keith Busch
2025-06-27 7:25 ` Christoph Hellwig
2025-06-27 15:34 ` Keith Busch
2025-06-30 6:00 ` Christoph Hellwig
2025-06-30 14:04 ` Keith Busch [this message]
2025-07-01 6:16 ` Christoph Hellwig
2025-07-01 12:15 ` Keith Busch
2025-07-01 14:35 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGKZf5gX7_JPe4-g@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox