Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: uring_cmd specific request_queue for SGLs
Date: Tue, 1 Jul 2025 08:15:39 -0400	[thread overview]
Message-ID: <aGPRa43FJW_B1asI@kbusch-mbp> (raw)
In-Reply-To: <20250701061609.GA17912@lst.de>

On Tue, Jul 01, 2025 at 08:16:09AM +0200, Christoph Hellwig wrote:
> On Mon, Jun 30, 2025 at 08:04:47AM -0600, Keith Busch wrote:
> > 
> >   a. Force the application to split each iovec into a separate command
> > 
> >   b. Relax the kernel's limits to match the hardware's capabilities
> > 
> > This patch is trying to do "b".
> 
> a, or a variant of that (not using passthrough) would in general be
> my preference.  Why is that not suitable here?

Why use passthrough? Because until very recently (as in the current rc),
passthrough had been the only way for user space to access write streams
and metadata.

We've had uring_cmd passthrough for several years now, so there's some
decently mature applications making use of it. But can they split
commands such that they dispatch one per iovec instead of as a single
command? I've asked that, still waiting to hear back. I sent this patch,
though, because they bought SGL capable hardware specifically so they
could do this. 


  reply	other threads:[~2025-07-01 13:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 21:14 [PATCH] nvme: uring_cmd specific request_queue for SGLs Keith Busch
2025-06-25  6:09 ` Christoph Hellwig
2025-06-25 22:08   ` Keith Busch
2025-06-26  5:14     ` Christoph Hellwig
2025-06-26 15:29       ` Keith Busch
2025-06-27  7:25         ` Christoph Hellwig
2025-06-27 15:34           ` Keith Busch
2025-06-30  6:00             ` Christoph Hellwig
2025-06-30 14:04               ` Keith Busch
2025-07-01  6:16                 ` Christoph Hellwig
2025-07-01 12:15                   ` Keith Busch [this message]
2025-07-01 14:35                     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGPRa43FJW_B1asI@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@meta.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox