Re: [PATCH v2 2/2] nvme: initialize known effects to set ns_mgmt NCC and ns_attach NIC

[Christoph Hellwig <hch@infradead.org>]

On Fri, Apr 24, 2026 at 02:51:48AM +0900, Tokunori Ikegami wrote:
> On 2026/04/23 14:57, Christoph Hellwig wrote:
> > Can you explain the rational a little better here?  Do you have a
> > device that does not have these entries?  And what problems does that
> > cause for you for which workload?
> 
> The change is just an idea to improvement the scan_work to make sure as
> always do scan for the ns_mgmt and ns_attach commands.
> Actually I do not have the device as I have only a drive these entries as
> NCC for ns_mgmt and NIC for ns_attach.
> (Another drive I have but does not support both ns_attach and ns_mgmt then
> does not have these entries. Also third drive broken then I can not confirm
> it for now.)
> All drives supporting ns_mgmt and ns_attach should have the entries but I do
> not think the driver side not needed to be depended on it as always do scan.

Please document this very clearly in the commit message, and maybe also
in code comments.

> I tried to fix the issue below with the changes at first but the issue was
> caused by the test script then currently resolved already.
>   <https://github.com/linux-nvme/nvme-cli/issues/3251>

I don't really understand how this is related.